network_traffic: add optional GeoIP enrichment #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added enhancement efd6 force-pushed the network_traffic_geoip branch from 8ead616 to 20b9e14 Compare 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Make the enrichment configurable to allow users with very high throughput and no need for geolocation to turn off enrichment, but set to on by default.
efd6 force-pushed the network_traffic_geoip branch from 20b9e14 to c9fed16 Compare 🌐 Coverage report
|
| Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
djptek approved these changes Dec 14, 2022
Contributor
djptek left a comment
djptek left a comment There was a problem hiding this comment.
LGTM
I looked at a few sample events and those seem to be 192.168.*.* or 127.0.0.1 so they wouldn't be impacted by these changes
| Package network_traffic - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds GeoIP enrichment to all network packet capture data streams. Some dashboard visualisations depend on geo location, which would currently require that users add the enrichment themselves in additional processors. Let's make it just work out of the box.
Make the enrichment configurable to allow users with very high throughput and no need for geolocation to turn off enrichment, but set to on by default.
Changes in kibana/ files are due to running
elastic-package format(almost entirely whitespace changes).Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots