Skip to content

ECS version update #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
muthu-mps merged 2 commits into from
Jan 9, 2023
Merged

ECS version update #4797

muthu-mps merged 2 commits into from
Jan 9, 2023

Conversation

@muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Dec 9, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

Updates the ECS version to 8.5.1 from 1.12. The system and pipeline tests are executed to generate new sample events.

Checklist

Refer #4792 for the checklist.

How to test this PR locally

Run system and pipeline test for activemq and apache integrations and make sure nothing is breaking. Verify the changes with ecs release notes.
@elasticmachine
Copy link

elasticmachine commented Dec 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-09T06:19:48.916+0000

  • Duration: 25 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 70
Skipped 0
Total 70

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Dec 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 66.667% (4/6) 👎 -30.794
Classes 66.667% (4/6) 👎 -30.794
Methods 79.688% (51/64) 👎 -11.58
Lines 74.265% (303/408) 👎 -17.986
Conditionals 100.0% (0/0) 💚
@muthu-mps muthu-mps marked this pull request as ready for review December 9, 2022 06:45
@muthu-mps muthu-mps requested a review from a team as a code owner December 9, 2022 06:45
@muthu-mps muthu-mps self-assigned this Dec 9, 2022
@botelastic
Copy link

botelastic bot commented Jan 8, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic bot added the Stalled label Jan 8, 2023
ishleenk17
ishleenk17 reviewed Jan 9, 2023
View reviewed changes
packages/activemq/data_stream/broker/sample_event.json
"name": "docker-fleet-agent",
"type": "metricbeat",
"version": "8.3.3"
"version": "8.5.0"
Copy link
Member

@ishleenk17 ishleenk17 Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ecs version is 8.5.1 and here it says 8.5.0
Copy link
Contributor Author

@muthu-mps muthu-mps Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 - This is agent version and not the ECS version.
@botelastic botelastic bot removed the Stalled label Jan 9, 2023
ishleenk17
ishleenk17 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@muthu-mps muthu-mps merged commit 81e1860 into elastic:main Jan 9, 2023
@elasticmachine
Copy link

elasticmachine commented Jan 9, 2023

Package activemq - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=activemq
@elasticmachine
Copy link

elasticmachine commented Jan 9, 2023

Package apache - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=apache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@muthu-mps @elasticmachine @ishleenk17