Skip to content

Conversation

@mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Nov 18, 2022

What does this PR do?

Adds an integration to support a new security capability in elastic-agent for detecting and preventing container drift.

Content for docs page is incomplete. Hopefully that can be addressed in subsequent PRs, as it could take time to get that content.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • mappings required for alerts datastream
  • mappings required for metrics datastream

How to test this PR locally

Related issues

Screenshots

image

@mitodrummer mitodrummer added enhancement New feature or request Team:Integrations Label for the Integrations team Team:AWP (Deprecated) labels Nov 18, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-20T22:11:18.932+0000

  • Duration: 14 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 18, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 42.857% (3/7)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
Copy link
Contributor

@lrishi lrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions and minor suggestions. Otherwise lgtm 👍🏽

Co-authored-by: Lovel Rishi <lrishi@users.noreply.github.com>
@mitodrummer mitodrummer marked this pull request as ready for review November 21, 2022 23:06
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@mitodrummer mitodrummer changed the title [DRAFT] integration stub created for new cloud_defend integration New integration created for "cloud_defend" for containers feature Nov 21, 2022
@mitodrummer mitodrummer requested review from a team and removed request for a team, dimadavid and learhy November 21, 2022 23:44
@mitodrummer mitodrummer added Team: Cloud Native Integrations and removed Team:AWP (Deprecated) Team:Integrations Label for the Integrations team labels Dec 20, 2022
mitodrummer added a commit to elastic/kibana that referenced this pull request Dec 20, 2022
## Summary New Kibana plugin created for an integration called "Cloud defend for containers" which will have a corresponding agent service which can proactively block and alert on executable creation or modification in a running container. This plugin is purely in place to configure the fleet policy UX around this new integration. For now we have added a yaml editor as a custom input to our integration. The monaco-yaml libary was added to allow support for JSON schema validation support for yaml. Integration PR is up, and a work in progress: (waiting on some content for the doc page) elastic/integrations#4680 ### Screenshot ![image](https://user-images.githubusercontent.com/16198204/207160791-73e11e05-953b-42ba-b4dd-a4904bd95451.png) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Karl Godard <karlgodard@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Copy link
Member

@norrietaylor norrietaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mitodrummer
Copy link
Contributor Author

/test

@elasticmachine
Copy link

Package cloud_defend - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=cloud_defend

@elasticmachine
Copy link

Package cloud_defend - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=cloud_defend

1 similar comment
@elasticmachine
Copy link

Package cloud_defend - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=cloud_defend

@andrewkroh andrewkroh added Integration:cloud_defend Defend for Containers (Deprecated) New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
@andrewkroh andrewkroh added Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] and removed Team: Cloud Native Integrations Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Sep 18, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@norrietaylor norrietaylor deleted the cloud_defend_v0.0.1_stub branch September 23, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cloud_defend Defend for Containers (Deprecated) New Integration Issue or pull request for creating a new integration package. Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] v8.7.0

8 participants