Skip to content

Conversation

@kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Nov 16, 2022

What does this PR do?

Current Scenario:
The field panw.panos.certificate.size is not always a long type. Populating error.message when the field failed to convert to long is causing confusion to users.

Change:

  • Remove the conversion of panw.panos.certificate.size to long and change it to keyword type to support string fields as well.
  • Convert only the ECS field tls.client.x509.public_key_size to long and on_failure remove the field, but not populate error.message which is misleading.
  • Keep the original field panw.panos.certificate.size for user reference

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Nov 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-16T11:00:51.531+0000

  • Duration: 19 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 16, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚 2.53
Classes 100.0% (15/15) 💚 2.53
Methods 98.529% (67/68) 👍 7.631
Lines 94.507% (3200/3386) 👍 2.81
Conditionals 100.0% (0/0) 💚
@kcreddy kcreddy changed the title Panw | panos.certificate.size datatype conversion Panw | Support text values on panos.certificate.size field Nov 16, 2022
@kcreddy kcreddy self-assigned this Nov 16, 2022
@kcreddy kcreddy added bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall labels Nov 16, 2022
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy closed this Nov 16, 2022
@kcreddy kcreddy deleted the panw_datatype_convert branch November 16, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall

2 participants