[microsoft_sqlserver] Establish Named instance connection by Instance Name #4501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andrewkroh changed the title 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
| /test benchmark fullreport |
| Microsoft SQL Server has a feature that allows running multiple databases on the same host (or clustered hosts) with separate settings. Edit the instance port and provide the named instance port to connect to the named instance and collect metrics. | ||
| See: [Instruction on how to configure server to listen Named Instance port](https://docs.microsoft.com/en-us/sql/database-engine/configure-windows/configure-a-server-to-listen-on-a-specific-tcp-port?view=sql-server-ver15) | ||
| Microsoft SQL Server has a feature that allows running multiple databases on the same host (or clustered hosts) with separate settings. Establish named instance connection by using the instance name along with the host name (Ex: `host/instance_name` or `host:named_instance_port`) to collect metrics. | ||
| |
There was a problem hiding this comment.
Let's provide detailed description here to avoid repeated user queries around this. There are couple of aspects that need to be clarified:
- As of now we support single host only. For multiple hosts, new integration need to be run. Need a section on it.
- What is the different syntax hosts can take with syntax description.
- Example of hosts with sample example values.
efd6 reviewed Oct 28, 2022
packages/microsoft_sqlserver/data_stream/performance/agent/stream/stream.yml.hbs Show resolved Hide resolved
efd6 approved these changes Oct 31, 2022
| | ||
| As of now the integration supports collecting metrics from single host. For multi host, each host needs to run a new integration. | ||
| | ||
| User has to provide the user name, password and the host name, |
There was a problem hiding this comment.
Can add the following line:
+ The host configuration also contains both named instance or port details, as per the syntax below,
| ### Connecting to Named Instance (host) | ||
| | ||
| * `host/instance_name` ex: `localhost/namedinstance_01` | ||
| * `host:named_instance_port` ex: `localhost:60873` |
Minor edits
| LGTM |
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Connection is established with and without port number and also with the Instance Name.
Checklist
changelog.ymlfile.How to test this PR locally