Skip to content

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Oct 5, 2022

What does this PR do?

Remove the 'Overview' heading at the doc beginning.

TIL that https://docs.elastic.co/integrations/azure automatically adds one on its own, so we should omit it in the source code to avoid duplicates.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

zmoog added 3 commits October 5, 2022 09:39
docs.elastic.co already add one, so we should omit it in the source.
I forgot to update the link 🤦‍♂️ (again)
@zmoog zmoog self-assigned this Oct 5, 2022
@zmoog zmoog added bug Something isn't working, use only for issues docs labels Oct 5, 2022
@zmoog zmoog marked this pull request as ready for review October 5, 2022 07:44
@zmoog zmoog requested a review from a team as a code owner October 5, 2022 07:44
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

🚀 Benchmarks report

Package azure 👍(1) 💚(1) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
springcloudlogs 3875.97 2087.68 -1788.29 (-46.14%) 💔
activitylogs 1312.34 636.13 -676.21 (-51.53%) 💔
application_gateway 2288.33 1592.36 -695.97 (-30.41%) 💔
auditlogs 1996.01 1259.45 -736.56 (-36.9%) 💔
firewall_logs 1980.2 1461.99 -518.21 (-26.17%) 💔
identity_protection 4237.29 2293.58 -1943.71 (-45.87%) 💔
platformlogs 3937.01 2583.98 -1353.03 (-34.37%) 💔
signinlogs 1980.2 1049.32 -930.88 (-47.01%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-05T08:31:42.857+0000

  • Duration: 12 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@zmoog zmoog requested a review from paolafrancesca October 5, 2022 11:23
@zmoog zmoog merged commit 44ad611 into main Oct 6, 2022
@zmoog zmoog deleted the azure-billing-metrics-remove-overview-heading branch October 6, 2022 08:36
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues documentation Improvements or additions to documentation. Applied to PRs that modify *.md files.

5 participants