- Notifications
You must be signed in to change notification settings - Fork 513
Azure Billing Metrics UX and docs update #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Billing Metrics UX and docs update #4219
Conversation
🌐 Coverage report
|
colleenmcginnis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @zmoog thanks for improving the docs!
I took a first look at the changes, and I have some concerns about the order of the content. A few months ago we developed documentation guidelines for integrations. Part of the intention behind the guidelines was to gradually introduce more complex information to the reader as they are deciding whether or not to use the integration, setting it up, and customizing it for their use case.
For example, here's the thought process a reader might go through when visiting the integration docs:
- The first thing they may want to know is what is this particular Azure integration for? (That should be covered in the Overview section.)
- They probably have in mind what kind of data they want from Azure. We should describe that in a bit more detail next (in the Data streams section) so they can be confident that they are looking at the right Azure integration before getting into the details of implementation.
- Then, once they are sold on this particular integration, we should be upfront about any requirements or limitations of the integration so they can again be confident that this integration will work with their use case (for example, knowing it will work with specific versions of a product). (This should be covered in the Requirements section.)
- Then, once they are sure this is the right integration and that there are no deal breakers for using this integration with their systems, they are ready to set up the integration both from the Elastic side and the Azure side. (This should be covered in the Setup section.)
- Finally, include additional information that is not necessarily required for all users to know, but may be very helpful to some. (This includes Reference content and Troubleshooting tips.)
If there's additional information to include that we think would be helpful to the reader, but does not fit into any of these categories (maybe "How it works" or "Cost"), we should talk about whether that should be added to the guidelines so other integrations can also benefit from those additions!
Let me know if you have any questions or concerns about reordering this content to align with the documentation guidelines (or if you would like me to make some changes to the order and commit them to this PR).
Hey @colleenmcginnis, I am more than happy to align this doc to the guidelines! Consistency is king. I was aware it existed from you mentioning it in other PRs, but I didn't recall it when I started! I will follow up with other comments. Thank you so much for spending some time on the review! |
| @colleenmcginnis, can I use the AWS docs as a reference [for minor details like headers, markdown syntax minutiae]? |
| Yes! AWS would be a good reference. Though AWS has the central AWS integration and I don't think that exists for Azure, right? We might be able to create a kind of "landing page" that is not associated with a specific integration, but contains an overview of Azure-related integrations if it would be helpful. |
| Hey, @colleenmcginnis, thanks again for clarifying the purpose of the guideline; I think it's a great thing.
I believe that both "How it works" and "Cost" sections do not deserve a spot at the top level of the guidelines: overview, data stream, requirements, setup, and reference work great. In this new revision, I am experimenting with this approach:
I also moved the "Settings" section at the end of the "Setup". The idea is to provide guidance about configuring the integration's setting page. Another approach would be to shrink this section by moving details in the field description on the setting page and leaving just a few field reference information, like the possible value for the endpoints ("Resource Manager Endpoint" and "Active Directory Endpoint"). @colleenmcginnis I'd love to know what you think. I'm open to suggestions and willing to move stuff around until we are both happy with the result. |
Scope options should be more prominent. Some parts of the integration assume a 24h period, so even if it is available to customization should be considered an advanced option.
These endpoints do not require customization in the general case, so we are moving them to the advanced section.
Rearrange the document section to meet the structure recommended by the documentation guidelines: https://github.com/elastic/integrations/blob/main/docs/documentation_guidelines.md I am experimenting with a few sub-sections to the "Setup" section (for example, "how it works" and "settings"). Open to feedback and suggestions! Also add a description to all the fields in the settings page.
This section contains the sources I used to write the bulk of the "Setup" section of the document.
c1891f1 to 9003e7c Compare
tommyers-elastic left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really great work - thanks maurizio
colleenmcginnis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this content flows now. Thanks for aligning it with the documentation guidelines!
I left lots of comments/suggestions below, but most are relatively small. Let me know if you have any questions or concerns!
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
The Azure Marketplace is the right destination.
4799974 to 9209021 Compare | @colleenmcginnis, do you think this PR needs more work on the docs? |
colleenmcginnis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments below, but after those are addressed this looks good from my side!
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
I hope this helps to clarify the scope mechanism.
What does this PR do?
Update the integration UX and documentation to enhance:
Checklist
I have verified that all data streams collect metrics or logs.changelog.ymlfile.How to test this PR locally
Screenshots
Settings
Documentation