Skip to content

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Sep 14, 2022

What does this PR do?

Update the integration UX and documentation to enhance:

  • How to create and configure the required App Registration.
  • How to use the scopes (subscription, department, and billing account).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Screenshots

Settings

CleanShot 2022-09-22 at 22 43 20@2x

Documentation

CleanShot 2022-09-22 at 22 26 17@2x

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-22T20:39:58.313+0000

  • Duration: 13 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@zmoog zmoog self-assigned this Sep 15, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Sep 15, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 15, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.65
Classes 100.0% (0/0) 💚 2.65
Methods 66.667% (2/3) 👎 -23.202
Lines 100.0% (0/0) 💚 8.671
Conditionals 100.0% (0/0) 💚
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @zmoog thanks for improving the docs!

I took a first look at the changes, and I have some concerns about the order of the content. A few months ago we developed documentation guidelines for integrations. Part of the intention behind the guidelines was to gradually introduce more complex information to the reader as they are deciding whether or not to use the integration, setting it up, and customizing it for their use case.

For example, here's the thought process a reader might go through when visiting the integration docs:

  1. The first thing they may want to know is what is this particular Azure integration for? (That should be covered in the Overview section.)
  2. They probably have in mind what kind of data they want from Azure. We should describe that in a bit more detail next (in the Data streams section) so they can be confident that they are looking at the right Azure integration before getting into the details of implementation.
  3. Then, once they are sold on this particular integration, we should be upfront about any requirements or limitations of the integration so they can again be confident that this integration will work with their use case (for example, knowing it will work with specific versions of a product). (This should be covered in the Requirements section.)
  4. Then, once they are sure this is the right integration and that there are no deal breakers for using this integration with their systems, they are ready to set up the integration both from the Elastic side and the Azure side. (This should be covered in the Setup section.)
  5. Finally, include additional information that is not necessarily required for all users to know, but may be very helpful to some. (This includes Reference content and Troubleshooting tips.)

If there's additional information to include that we think would be helpful to the reader, but does not fit into any of these categories (maybe "How it works" or "Cost"), we should talk about whether that should be added to the guidelines so other integrations can also benefit from those additions!

Let me know if you have any questions or concerns about reordering this content to align with the documentation guidelines (or if you would like me to make some changes to the order and commit them to this PR).

@zmoog
Copy link
Contributor Author

zmoog commented Sep 15, 2022

Let me know if you have any questions or concerns about reordering this content to align with the documentation guidelines

Hey @colleenmcginnis, I am more than happy to align this doc to the guidelines! Consistency is king. I was aware it existed from you mentioning it in other PRs, but I didn't recall it when I started!

I will follow up with other comments.

Thank you so much for spending some time on the review!

@zmoog
Copy link
Contributor Author

zmoog commented Sep 15, 2022

@colleenmcginnis, can I use the AWS docs as a reference [for minor details like headers, markdown syntax minutiae]?

@colleenmcginnis
Copy link
Contributor

Yes! AWS would be a good reference. Though AWS has the central AWS integration and I don't think that exists for Azure, right?

We might be able to create a kind of "landing page" that is not associated with a specific integration, but contains an overview of Azure-related integrations if it would be helpful.

@zmoog
Copy link
Contributor Author

zmoog commented Sep 17, 2022

Hey, @colleenmcginnis, thanks again for clarifying the purpose of the guideline; I think it's a great thing.

If there's additional information to include that we think would be helpful to the reade, but does not fit into any of these categories (maybe "How it works" or "Cost"), we should talk about whether that should be added to the guidelines so other integrations can also benefit from those additions!

I believe that both "How it works" and "Cost" sections do not deserve a spot at the top level of the guidelines: overview, data stream, requirements, setup, and reference work great.

In this new revision, I am experimenting with this approach:

  • Moved "How it works" as a sub-section in Setup, so users can have an idea of what we are setting up at a glance. It's more of a visual overview of the result.
  • Moved "Cost" as a sub-section of Requirement. I'm not 100% sure, but it may be a good fit in the section that should summarize the requirements and limitations. Like you are required to spend a little money to pull this data from Azure.

I also moved the "Settings" section at the end of the "Setup". The idea is to provide guidance about configuring the integration's setting page. Another approach would be to shrink this section by moving details in the field description on the setting page and leaving just a few field reference information, like the possible value for the endpoints ("Resource Manager Endpoint" and "Active Directory Endpoint").

@colleenmcginnis I'd love to know what you think. I'm open to suggestions and willing to move stuff around until we are both happy with the result.

@zmoog zmoog marked this pull request as ready for review September 17, 2022 16:51
@zmoog zmoog requested a review from a team as a code owner September 17, 2022 16:51
Scope options should be more prominent. Some parts of the integration assume a 24h period, so even if it is available to customization should be considered an advanced option.
These endpoints do not require customization in the general case, so we are moving them to the advanced section.
Rearrange the document section to meet the structure recommended by the documentation guidelines: https://github.com/elastic/integrations/blob/main/docs/documentation_guidelines.md I am experimenting with a few sub-sections to the "Setup" section (for example, "how it works" and "settings"). Open to feedback and suggestions! Also add a description to all the fields in the settings page.
This section contains the sources I used to write the bulk of the "Setup" section of the document.
@zmoog zmoog force-pushed the azure-billing-metrics-ux-and-docs-update branch from c1891f1 to 9003e7c Compare September 20, 2022 08:49
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really great work - thanks maurizio

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this content flows now. Thanks for aligning it with the documentation guidelines!

I left lots of comments/suggestions below, but most are relatively small. Let me know if you have any questions or concerns!

@zmoog zmoog force-pushed the azure-billing-metrics-ux-and-docs-update branch from 4799974 to 9209021 Compare September 20, 2022 21:29
@zmoog
Copy link
Contributor Author

zmoog commented Sep 22, 2022

@colleenmcginnis, do you think this PR needs more work on the docs?

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments below, but after those are addressed this looks good from my side!

zmoog and others added 3 commits September 22, 2022 22:06
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
I hope this helps to clarify the scope mechanism.
@zmoog zmoog merged commit d4bde70 into elastic:main Sep 26, 2022
@zmoog zmoog deleted the azure-billing-metrics-ux-and-docs-update branch September 26, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants