Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 19, 2022

What does this PR do?

This improves handling of authentication events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 19, 2022
@efd6 efd6 force-pushed the b32230-checkpoint branch from 2e4dd31 to 2e43123 Compare July 19, 2022 08:23
@elasticmachine
Copy link

elasticmachine commented Jul 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T21:16:13.384+0000

  • Duration: 23 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Jul 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.012
Classes 100.0% (1/1) 💚 3.012
Methods 100.0% (15/15) 💚 10.95
Lines 82.918% (665/802) 👎 -7.561
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review July 19, 2022 08:42
@efd6 efd6 requested a review from a team as a code owner July 19, 2022 08:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leweafan
Copy link

@efd6 here event.outcome = "failure" missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point

4 participants