Skip to content

[IBM MQ] Add Integration Package with Error Log Data Stream #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 18, 2022
Merged

[IBM MQ] Add Integration Package with Error Log Data Stream #3590

merged 12 commits into from
Jul 18, 2022

Conversation

@harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Jun 27, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of IBM MQ integration package.
  • Added 1 data stream (Queue Manager Error Logs).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ibmmq directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

IBM MQ errorlog dashboard
@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T05:12:59.648+0000

  • Duration: 17 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@yug-rajani
Copy link
Contributor

yug-rajani commented Jun 27, 2022

/test
@yug-rajani yug-rajani added enhancement New feature or request Integration:ibmmq IBM MQ Team:Service-Integrations Label for the Observability Service Integrations team labels Jun 27, 2022
@yug-rajani yug-rajani linked an issue Jun 27, 2022 that may be closed by this pull request
Create IBM MQ package #620
Closed
8 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.145
Classes 100.0% (1/1) 💚 3.145
Methods 100.0% (13/13) 💚 10.478
Lines 95.0% (95/100) 👍 3.927
Conditionals 100.0% (0/0) 💚
@yug-rajani yug-rajani changed the title Add foundation, errorlog data stream, visualizations [IBM MQ] Add foundation, errorlog data stream, visualizations Jun 27, 2022
@harnish-crest harnish-crest changed the title [IBM MQ] Add foundation, errorlog data stream, visualizations [IBM MQ] Add Integration Package with Error Log Data Stream Jun 28, 2022
@yug-rajani yug-rajani removed the request for review from lalit-satapathy June 28, 2022 06:13
@yug-rajani yug-rajani requested a review from kush-elastic June 28, 2022 12:37
@yug-rajani
Copy link
Contributor

yug-rajani commented Jun 28, 2022

/test
kush-elastic
kush-elastic suggested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change docker image tag from latest to specific version and lets use variants.yml for multiple version test.
@yug-rajani
Copy link
Contributor

yug-rajani commented Jun 29, 2022

/test
kush-elastic
kush-elastic approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.
else LGTM!
@lalit-satapathy lalit-satapathy requested a review from ritalwar June 30, 2022 12:39
@harnish-crest harnish-crest mentioned this pull request Jul 1, 2022
Merged
4 tasks
kush-elastic
kush-elastic approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ritalwar
ritalwar reviewed Jul 7, 2022
View reviewed changes
@harnish-crest harnish-crest requested a review from ritalwar July 7, 2022 13:24
ritalwar
ritalwar reviewed Jul 7, 2022
View reviewed changes
@harnish-crest harnish-crest requested a review from ritalwar July 8, 2022 05:18
ritalwar
ritalwar reviewed Jul 8, 2022
View reviewed changes
ritalwar
ritalwar reviewed Jul 8, 2022
View reviewed changes
@harnish-crest harnish-crest requested a review from ritalwar July 8, 2022 10:35
ritalwar
ritalwar reviewed Jul 14, 2022
View reviewed changes
@harnish-crest harnish-crest requested a review from ritalwar July 14, 2022 09:45
ritalwar
ritalwar approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@yug-rajani yug-rajani merged commit 1fc6a88 into elastic:main Jul 18, 2022
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:ibmmq IBM MQ New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team

6 participants

@harnish-crest @elasticmachine @yug-rajani @kush-elastic @ritalwar @andrewkroh