Skip to content

panw: fix terms in saved search #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2022
Merged

panw: fix terms in saved search #3324

merged 3 commits into from
May 15, 2022

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 11, 2022 •
edited
Loading

This brings the searches into line with the changes made in #3094. The granularity
of event fields is not fine enough within the panw integration to be able to replicate
the behaviour that previously existed, so the panw.panos.type field is used instead.

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

See #3016 (comment)

Related issues

Screenshots
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels May 11, 2022
@efd6 efd6 requested a review from a team as a code owner May 11, 2022 08:17
@efd6 efd6 self-assigned this May 11, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 commented May 11, 2022
View reviewed changes
@efd6
panw: fix terms in saved search
2a662e1 
This brings the searches into line with the changes made in elastic#3094. The granularity of event fields is not fine enough within the panw integration to be able to replicate the behaviour that previously existed, so the panw.panos.type field is used instead.
@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-15T06:04:39.619+0000

  • Duration: 17 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (6/6) 💚 3.625
Classes 100.0% (6/6) 💚 3.625
Methods 100.0% (34/34) 💚 10.852
Lines 87.059% (814/935) 👎 -2.653
Conditionals 100.0% (0/0) 💚
@efd6 efd6 merged commit 7d7ae62 into elastic:main May 15, 2022
This was referenced May 22, 2022
Closed
Merged
@efd6 efd6 deleted the 3321-panw branch February 5, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall

3 participants

@efd6 @elasticmachine @r00tu53r