Skip to content

[juniper_srx] Improve TCP input #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2022
Merged

[juniper_srx] Improve TCP input #3320

merged 4 commits into from
May 12, 2022

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

What does this PR do?

  • Add TLS support to TCP input
  • Add custom TCP options support

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/juniper_srx && elastic-package test

Related issues

Screenshots

juniper_srx
@taylor-swanson
[juniper_srx] Improve TCP input
f26c9d0 
- Add TLS support to TCP input - Add custom TCP options support
@taylor-swanson
Update changelog with PR number
9de9028
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:55.884+0000

  • Duration: 18 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (7/7) 💚 3.597
Classes 100.0% (7/7) 💚 3.597
Methods 100.0% (50/50) 💚 11.753
Lines 70.799% (1525/2154) 👎 -18.314
Conditionals 100.0% (0/0) 💚
@taylor-swanson taylor-swanson marked this pull request as ready for review May 10, 2022 16:22
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 10, 2022 16:22
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a TLS test?
@taylor-swanson
Copy link
Contributor Author

taylor-swanson commented May 11, 2022

Will there be a TLS test?

I thought about it originally and was overthinking the complexity of setting that up. I just tested it and it turns out it's trivial to set up and hard code the cert/key pair (we won't test validating certificates). I'll add a TLS test here and to the other packages as well.
@taylor-swanson
Copy link
Contributor Author

taylor-swanson commented May 11, 2022

TLS test has been added.
@taylor-swanson taylor-swanson merged commit 427b396 into elastic:main May 12, 2022
@taylor-swanson taylor-swanson deleted the inputs-juniper-srx branch May 12, 2022 19:48
This was referenced May 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@taylor-swanson @elasticmachine @efd6