Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to deprecate s3 input as an option in CloudWatch integration. Logs sent to CloudWatch can be ingested into elasticsearch directly via cloudwatch input. There is no need to send them to an S3 bucket and then to ealsticsearch.
Screen Shot 2022-05-09 at 2 15 14 PM

Also this PR also enhanced the description for cloudwatch integration.
Screen Shot 2022-05-09 at 1 26 42 PM

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 9, 2022 20:19
@elasticmachine
Copy link

elasticmachine commented May 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-10T15:33:03.432+0000

  • Duration: 31 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@kaiyan-sheng kaiyan-sheng self-assigned this May 9, 2022
@elasticmachine
Copy link

elasticmachine commented May 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.745
Classes 91.667% (11/12) 👎 -4.745
Methods 82.439% (169/205) 👎 -5.845
Lines 92.673% (2087/2252) 👍 3.645
Conditionals 100.0% (0/0) 💚
@kaiyan-sheng kaiyan-sheng merged commit 3ba13dc into elastic:main May 11, 2022
@kaiyan-sheng kaiyan-sheng deleted the deprecate_s3 branch May 11, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants