Skip to content

1password: change name of package "1Password Event Reporting" => "1Password" #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

1password: change name of package "1Password Event Reporting" => "1Password" #3245

merged 2 commits into from
May 3, 2022

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 2, 2022

What does this PR do?

This changes the name of the package to just be the name of the vendor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:1password 1Password (Partner supported) labels May 2, 2022
@efd6 efd6 self-assigned this May 2, 2022
@efd6 efd6 requested a review from a team as a code owner May 2, 2022 04:38
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 commented May 2, 2022
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented May 2, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-02T04:40:04.794+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.857
Classes 100.0% (2/2) 💚 2.857
Methods 90.909% (20/22) 👍 2.076
Lines 92.793% (206/222) 👍 2.76
Conditionals 100.0% (0/0) 💚
@efd6
Copy link
Contributor Author

efd6 commented May 2, 2022

/cc @jamiehynds
r00tu53r
r00tu53r reviewed May 2, 2022
View reviewed changes
@efd6 efd6 merged commit 7022539 into elastic:main May 3, 2022
@andrewkroh andrewkroh mentioned this pull request May 9, 2022
Merged
@efd6 efd6 deleted the 2722-1password branch February 5, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:1password 1Password (Partner supported)

3 participants

@efd6 @elasticmachine @r00tu53r