Skip to content

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Fixes processing of ModifiedProperties when it is a list of strings
instead of a list of objects

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack up -d eval "$(elastic-package stack shellinit)" elastic-package test elastic-package stack down
@leehinman leehinman requested a review from a team as a code owner April 26, 2022 20:35
@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Apr 26, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

- Fix processing of ModifiedProperties when it is a list of strings
@leehinman leehinman force-pushed the 5872_o365_painless_bug branch from be6d98f to 6a8c619 Compare April 26, 2022 20:46
@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-26T20:46:35.223+0000

  • Duration: 12 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.918
Classes 100.0% (1/1) 💚 2.918
Methods 100.0% (15/15) 💚 12.106
Lines 80.704% (665/824) 👎 -7.975
Conditionals 100.0% (0/0) 💚
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit 2ebe9fb into elastic:main Apr 27, 2022
@leehinman leehinman deleted the 5872_o365_painless_bug branch July 18, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants