Skip to content

[IBM WebSphere Application Server] Add WebSphere Application Server Integration Package with ThreadPool data stream #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 26, 2022
Merged

[IBM WebSphere Application Server] Add WebSphere Application Server Integration Package with ThreadPool data stream #3138

merged 11 commits into from
May 26, 2022

Conversation

@kush-elastic
Copy link
Contributor

@kush-elastic kush-elastic commented Apr 20, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of WebSphere Application Server integration package.
  • Added 1 data stream (threadpool).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added pipeline test cases for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/websphere_application_server directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

websphere_application_server-threadpool-dashboard-screenshot
This was referenced Apr 20, 2022
Merged
Merged
@elasticmachine
Copy link

elasticmachine commented Apr 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-25T06:12:50.199+0000

  • Duration: 24 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@kush-elastic kush-elastic self-assigned this Apr 22, 2022
@kush-elastic kush-elastic added enhancement New feature or request Integration:websphere_application_server WebSphere Application Server labels Apr 26, 2022
@kush-elastic kush-elastic mentioned this pull request Apr 26, 2022
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.686
Classes 100.0% (3/3) 💚 3.686
Methods 100.0% (21/21) 💚 11.812
Lines 100.0% (356/356) 💚 10.234
Conditionals 100.0% (0/0) 💚
@kush-elastic kush-elastic mentioned this pull request Apr 29, 2022
Closed
4 tasks
@kush-elastic kush-elastic added New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 29, 2022
@kush-elastic kush-elastic mentioned this pull request May 4, 2022
Closed
4 tasks
@kush-elastic kush-elastic linked an issue May 11, 2022 that may be closed by this pull request
Create IBM Websphere Application Server Integration #2847
Closed
8 tasks
ishleenk17
ishleenk17 reviewed May 25, 2022
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-fields.yml should have the event.* fields
@kush-elastic kush-elastic marked this pull request as ready for review May 25, 2022 05:38
@kush-elastic kush-elastic requested a review from a team as a code owner May 25, 2022 05:38
@kush-elastic kush-elastic requested a review from yug-rajani May 25, 2022 05:38
yug-rajani
yug-rajani approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust a couple of suggested nits, LGTM otherwise!
@kush-elastic kush-elastic requested a review from ishleenk17 May 25, 2022 06:13
@yug-rajani yug-rajani merged commit c391973 into elastic:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:websphere_application_server WebSphere Application Server New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team

4 participants

@kush-elastic @elasticmachine @yug-rajani @ishleenk17