Skip to content

Update Atlassian Confluence Readme #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2022
Merged

Update Atlassian Confluence Readme #3062

merged 6 commits into from
Apr 14, 2022

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 11, 2022 •
edited
Loading

Added link to Atlassian documentation

Type of change

  • Enhancement

What does this PR do?

Added link to Atlassian documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@GinnyGalicia
Update Readme
6974dc4 
Added link to Atlassian documentation
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 11, 2022 15:35
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-14T00:58:22.401+0000

  • Duration: 14 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6
Copy link
Contributor

efd6 commented Apr 12, 2022

/test
@r00tu53r r00tu53r added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Security-External Integrations Integration:atlassian_confluence Atlassian Confluence (Community supported) labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
andrewkroh
andrewkroh reviewed Apr 12, 2022
View reviewed changes
r00tu53r
r00tu53r reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletions indicated in docs/README.md for field docs (host.os.name.text ..... user.target.name.text) shouldn't be here.

I think its because the updated docs/README.md has not been committed/pushed. Please apply these steps for all the open PRs.

  • Change readme under _dev/build/docs/README.md (if it exists)
  • Run elastic-package build
  • Commit _dev/build/docs/README.md and docs/README.md
  • Push changes
@ellis-elastic
Update Readme
34a3745 
Added additional link
@ellis-elastic
Update changelog
f1bf256 
Corrected PR URL
@ellis-elastic
Ran build
a93ad81
@ellis-elastic
Update Readme build
7297103 
using elastic-package v0.46.1
@ellis-elastic
Copy link
Contributor Author

I've installed v0.46.1 and re run build
@r00tu53r
Copy link
Contributor

/test
@ellis-elastic ellis-elastic merged commit fbd97e3 into elastic:main Apr 14, 2022
@andrewkroh andrewkroh mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:atlassian_confluence Atlassian Confluence (Community supported)

6 participants

@ellis-elastic @elasticmachine @efd6 @r00tu53r @andrewkroh @GinnyGalicia