Skip to content

[nagios] Add Nagios package with Host data stream #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 4, 2022
Merged

[nagios] Add Nagios package with Host data stream #2942

merged 8 commits into from
Apr 4, 2022

Conversation

@kush-elastic
Copy link
Contributor

@kush-elastic kush-elastic commented Mar 30, 2022

  • Enhancement

What does this PR do?

  • Generated the skeleton of Nagios integration package.
  • Added 1 data stream (Host).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/nagios_xi directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots
@kush-elastic kush-elastic requested a review from a team as a code owner March 30, 2022 17:41
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T12:35:29.055+0000

  • Duration: 13 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@kush-elastic kush-elastic requested a review from mtojek March 30, 2022 19:19
kush-elastic
kush-elastic commented Mar 30, 2022
View reviewed changes
packages/nagios_xi/manifest.yml Outdated
- monitoring
release: beta
conditions:
kibana.version: ^8.0.0
Copy link
Contributor Author

@kush-elastic kush-elastic Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated with 8.2.0 after testing this integration on 8.2.0.
@kush-elastic kush-elastic self-assigned this Mar 30, 2022
@kush-elastic kush-elastic added enhancement New feature or request Team:Integrations Label for the Integrations team New Integration Issue or pull request for creating a new integration package. labels Mar 30, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2022

Pinging @elastic/integrations (Team:Integrations)
@kush-elastic kush-elastic mentioned this pull request Mar 31, 2022
Closed
4 tasks
@kush-elastic kush-elastic marked this pull request as draft March 31, 2022 09:06
mtojek
mtojek approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a bit inconsistent as you're posting a screenshot with a dashboard that is not there, but that's fine :) We will fix it later.

I left a few nit-picks to address, but in general it's LGTM
packages/nagios_xi/_dev/build/docs/README.md Outdated

### Host Metrics

This is the `host` dataset.
Copy link
Contributor

@mtojek mtojek Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: data stream
packages/nagios_xi/data_stream/host/agent/stream/stream.yml.hbs Outdated
response.split:
target: body.hoststatus
type: array

Copy link
Contributor

@mtojek mtojek Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line
packages/nagios_xi/data_stream/host/fields/fields.yml
- name: nagios_xi
type: group
fields:
- name: host
Copy link
Contributor

@mtojek mtojek Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any place from where we can pull descriptions for all those fields? For example take a look at osquery_manager.
Copy link
Contributor Author

@kush-elastic kush-elastic Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will check it out.
packages/nagios_xi/manifest.yml Outdated
categories:
- custom
- monitoring
release: beta
Copy link
Contributor

@mtojek mtojek Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the release tag as we deprecated it. See: link.

I guess that you can apply the same to fields files.
Copy link
Contributor Author

@kush-elastic kush-elastic Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will remove it.
Thanks
@mtojek mtojek mentioned this pull request Mar 31, 2022
Merged
4 tasks
@kush-elastic kush-elastic requested a review from mtojek April 1, 2022 04:55
mtojek
mtojek reviewed Apr 1, 2022
View reviewed changes
packages/nagios_xi/manifest.yml Outdated
- monitoring
release: beta
conditions:
kibana.version: ^8.0.0
Copy link
Contributor

@mtojek mtojek Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you have already updated references to 8.2.0 in a few places (ecs, tests, sample event), I suppose you need to bump it also here now.
@kush-elastic kush-elastic marked this pull request as ready for review April 1, 2022 12:11
@kush-elastic kush-elastic requested a review from a team as a code owner April 1, 2022 12:11
@kush-elastic kush-elastic requested a review from mtojek April 1, 2022 12:31
mtojek
mtojek reviewed Apr 1, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment only, but may require to regenerate some files.
packages/nagios_xi/data_stream/host/elasticsearch/ingest_pipeline/default.yml Outdated
processors:
- set:
field: ecs.version
value: 8.2.0
Copy link
Contributor

@mtojek mtojek Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that it should be 8.1.0 to be consistent.
Copy link
Contributor Author

@kush-elastic kush-elastic Apr 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right,
There was confusion on which one to use 8.1.0 or 8.2.0.
Decided to go 8.1.0 for now.
Thanks
@kush-elastic kush-elastic requested a review from mtojek April 4, 2022 06:32
@masci masci requested a review from a team April 4, 2022 12:15
@mtojek mtojek marked this pull request as draft April 4, 2022 12:42
@mtojek mtojek marked this pull request as ready for review April 4, 2022 12:42
@mtojek mtojek marked this pull request as draft April 4, 2022 12:42
@mtojek mtojek marked this pull request as ready for review April 4, 2022 12:43
@kush-elastic kush-elastic marked this pull request as draft April 4, 2022 12:44
@kush-elastic kush-elastic marked this pull request as ready for review April 4, 2022 12:44
@kush-elastic kush-elastic merged commit 3960ce2 into elastic:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team

4 participants

@kush-elastic @elasticmachine @masci @mtojek