Skip to content

[hashicorp_vault] Make hashicorp_vault.audit.request.id optional in pipeline #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2022
Merged

[hashicorp_vault] Make hashicorp_vault.audit.request.id optional in pipeline #2471

merged 3 commits into from
Jan 6, 2022

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 6, 2022 •
edited
Loading

What does this PR do?

Fixes error:

field [id] not present as part of path [hashicorp_vault.audit.request.id]

Removes event.ingested from the pipelines because it's added by the Fleet final_pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@andrewkroh
Make request.id optional in pipeline
1919948 
Fixes error: field [id] not present as part of path [hashicorp_vault.audit.request.id]
@andrewkroh
Remove event.ingested
7b5a6a1
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jan 6, 2022
@elasticmachine
Copy link

elasticmachine commented Jan 6, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

elasticmachine commented Jan 6, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-06T01:01:25.589+0000

  • Duration: 18 min 38 sec

  • Commit: ce988c8

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@andrewkroh andrewkroh requested a review from a team January 6, 2022 01:41
efd6
efd6 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for this?
@andrewkroh
Copy link
Member Author

andrewkroh commented Jan 6, 2022

No issue. I was checking my own logs for error.message:* and discovered the issue.
@andrewkroh andrewkroh merged commit b85e87a into elastic:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@andrewkroh @elasticmachine @efd6