- Notifications
You must be signed in to change notification settings - Fork 513
Checkpoint Filebeat Module #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Pinging @elastic/integrations (Team:Integrations) |
| Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededExpand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
| title: Check Point firewall logs | ||
| release: beta | ||
| streams: | ||
| - input: syslog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewkroh do you happen to know if the syslog input adds any implicit fields like the logfile input by any chance? Checking the configuration only through the file input, so not entirely sure if I'm missing anything.
mtojek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it would be much more convenient for you to review integrations inside the team. You don't need specifically our approvals (Nicolas, me) on this. We can verify the package format, but can't say too much about pipeline definitions.
Sure thing, wasn't sure if you guys wanted to verify the first few packages coming from us or not to make sure we weren't doing something dumb 😅 , but definitely don't want to bombard you with like 20+ reviews for our team. |
| No worries, I saw you perform well with integrations, so need to check on them. Small request on my side: could you please configure your GH team (elastic/security-ingest) to have write perms to the package-storage? We configured a bot responsible for transferring changes from integrations to the package-storage. |
What does this PR do?
Imports and implements the Checkpoint filebeat module
Checklist
Screenshots