Skip to content

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 8, 2021

What does this PR do?

This PR is to add integration for AWS S3 Storage Lens to collect metrics listed here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage_lens_metrics_glossary.html

This integration will be experimental for now.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Screenshots

Screen Shot 2021-11-08 at 2 28 55 PM

@kaiyan-sheng kaiyan-sheng self-assigned this Nov 8, 2021
@elasticmachine
Copy link

elasticmachine commented Nov 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-09T17:45:43.725+0000

  • Duration: 27 min 43 sec

  • Commit: 2cce00d

Test stats 🧪

Test Results
Failed 0
Passed 262
Skipped 0
Total 262

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented Nov 9, 2021

Thanks for the review @aspacca ! Before merging, one question here: @ravikesarwani Should we have an S3 storage lens as a separate tile on the integrations page or should it be under the AWS S3 tile?

@ravikesarwani
Copy link

Kaiyan & I touch based on this and decided to keep this integration as separate from the current AWS S3 tile.
The main reason is the differences in the use case (organization wide), user persona (different users in the AWS org may configure/look at this data) and need for explicit enablement of these metrics (user needs to enable and define the org/account/buckets and also select free/paid).
Also the namespace and thus the resulting data stream where the data is stored is separate as well.

@kaiyan-sheng
Copy link
Contributor Author

Adding dashboard for s3 storage lens will be in a separate PR.

@kaiyan-sheng kaiyan-sheng merged commit a709714 into elastic:master Nov 9, 2021
@kaiyan-sheng kaiyan-sheng deleted the add_s3_storage_lens branch November 9, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants