Skip to content

Conversation

@leehinman
Copy link
Contributor

What does this PR do?

Prevents pipeline script error in windows integration

  • prevent creating new HashMap with null
  • improve error.message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

elastic-package test pipeline

Related issues

@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Oct 6, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

- prevent creating new HashMap with null - improve error.message Relates elastic#1789
@leehinman leehinman force-pushed the windows_hashmap_null_safe branch from fedc3f6 to 2a15657 Compare October 6, 2021 01:54
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-06T01:55:14.106+0000

  • Duration: 17 min 29 sec

  • Commit: 2a15657

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@leehinman leehinman merged commit 0ff6502 into elastic:master Oct 6, 2021
@leehinman leehinman deleted the windows_hashmap_null_safe branch October 6, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants