Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

cloudflare: don't update fleet health status to degraded pagination completes Earlier, we were using `.last_response.page` to get the last page index. Since `.last_response.page` starts with the value 0 at every interval, this resulted in collecting the first page 2 times. To prevent this, we've used `.last_response.url.params.Get "page"`. This change bumps minimum Kibana version to ^8.19.4 || ~9.0.7 || ^9.1.4 and adds `do_not_log_failure: true` in set transforms to avoid updating fleet health status to degraded. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cloudflare directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic self-assigned this Dec 22, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner December 22, 2025 13:18
@brijesh-elastic brijesh-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cloudflare Cloudflare (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Dec 22, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @brijesh-elastic

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brijesh-elastic brijesh-elastic merged commit fba133b into elastic:main Dec 23, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package cloudflare - 2.32.0 containing this change is available at https://epr.elastic.co/package/cloudflare/2.32.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cloudflare Cloudflare (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

3 participants