Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

qualys_gav: update data collection to get unique identifiers for each interval This will help to debug if there is any issue in data ingestion. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/qualys_gav directory.
  • Run the following command to run tests.

elastic-package test

Related issues

…ique identifiers for each interval of ingestion
@brijesh-elastic brijesh-elastic self-assigned this Dec 17, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner December 17, 2025 06:15
@brijesh-elastic brijesh-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:qualys_gav Qualys Global AssetView Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Dec 17, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay except what looks like some duplication in the ingest pipeline.

Copy link
Contributor

@clement-fouque clement-fouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great but I could only validated this PR partially as I can't perform a full ingest due to this bug: #16517

Image
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

@brijesh-elastic
Copy link
Collaborator Author

PR looks great but I could only validated this PR partially as I can't perform a full ingest due to this bug: #16517

Image

Thanks @clement-fouque, We will look into the bug and resolve it separately.

@brijesh-elastic brijesh-elastic merged commit f3dd729 into elastic:main Dec 19, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package qualys_gav - 0.7.0 containing this change is available at https://epr.elastic.co/package/qualys_gav/0.7.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:qualys_gav Qualys Global AssetView Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

4 participants