Skip to content

Conversation

@mauri870
Copy link
Member

Proposed commit message

The default Kafka protocol version depends on the filebeat version. For 8.x it defaults to 1.0.0, and for 9.0+ it defaults to 2.1.0. Update the description to clarify this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@mauri870 mauri870 self-assigned this Dec 11, 2025
@mauri870 mauri870 requested a review from a team as a code owner December 11, 2025 19:07
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Integration:kafka_log Custom Kafka Logs bugfix Pull request that fixes a bug issue labels Dec 11, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 force-pushed the kafka-default-version branch from e9daafb to 62a53d2 Compare December 11, 2025 19:08
@mauri870 mauri870 force-pushed the kafka-default-version branch from 62a53d2 to 7f5588c Compare December 11, 2025 19:32
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mauri870

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Dec 11, 2025
@lalit-satapathy
Copy link
Contributor

@agithomas / @stefans-elastic for review, given recent kafka upgrades.

@agithomas
Copy link
Contributor

The change looks good to me. My suggestion would be to add a troubleshooting section in the README document to help those users migrating from the 8.x+ stack to the 9.x+ stack. In that process, the users would fail to notice this dependency.

@stefans-elastic , as you have worked on the sarama library dependency issue pertaining to the metrics, kindly check from your end as well. Thanks.

Copy link
Contributor

@stefans-elastic stefans-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree: the change looks good. Also it matches the version we use in metricbeat.
Overall according to sarama code comment it is better to use lower version in sarama config than actual Kafka version it is running against because otherwise it may lead to random breakages.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval based on the above-mentioned validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:kafka_log Custom Kafka Logs Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

6 participants