Skip to content

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Dec 9, 2025

Proposed commit message

Removed tab characters from field descriptions in multiple packages that were causing validation issues for PyYAML users. Tab characters appeared both as leading whitespace and trailing characters in description values. Affected packages: - akamai: removed trailing tab from client_reputation description - checkpoint_harmony_endpoint: removed leading tabs from multiple field descriptions across antibot, zerophishing, urlfiltering, forensics, and threatextraction data streams - o365_metrics: removed leading tab from caller_network description - cisco_secure_email_gateway: removed tab from upload.action description and improved clarity of field documentation Fixes #15913 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

grep -rn $'\t' packages/**/fields/*.yml

Related issues

References

Screenshot 2025-12-09 at 09 50 23
@andrewkroh andrewkroh force-pushed the bugfix/remove-tabs-fields-yml branch from 1f44b41 to 012b122 Compare December 9, 2025 14:44
Removed tab characters from field descriptions in multiple packages that were causing validation issues. Tab characters appeared both as leading whitespace and trailing characters in description values. Affected packages: - akamai: removed trailing tab from client_reputation description - checkpoint_harmony_endpoint: removed leading tabs from multiple field descriptions across antibot, zerophishing, urlfiltering, forensics, and threatextraction data streams - o365_metrics: removed leading tab from caller_network description - cisco_secure_email_gateway: removed tab from upload.action description and improved clarity of field documentation Additionally improved the upload.action field description in cisco_secure_email_gateway to be more concise and clearer based on official Cisco documentation. Fixes elastic#15913
@andrewkroh andrewkroh force-pushed the bugfix/remove-tabs-fields-yml branch from 012b122 to 561d780 Compare December 9, 2025 14:45
@andrewkroh andrewkroh marked this pull request as ready for review December 9, 2025 14:45
@andrewkroh andrewkroh requested review from a team as code owners December 9, 2025 14:45
@andrewkroh andrewkroh added Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:o365_metrics Microsoft Office 365 Metrics Integration:akamai Akamai (Community supported) Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 9, 2025
@elasticmachine
Copy link

Pinging @elastic/integration-experience (Team:Integration-Experience)

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package checkpoint_harmony_endpoint 👍(2) 💚(0) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
antibot 2518.89 1485.88 -1033.01 (-41.01%) 💔
antimalware 4672.9 2247.19 -2425.71 (-51.91%) 💔
forensics 4184.1 2906.98 -1277.12 (-30.52%) 💔
threatextraction 4366.81 3164.56 -1202.25 (-27.53%) 💔
urlfiltering 3703.7 2958.58 -745.12 (-20.12%) 💔

Package o365_metrics 👍(12) 💚(2) 💔(7)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
outlook_app_usage_version_counts 8474.58 6802.72 -1671.86 (-19.73%) 💔
sharepoint_site_usage_detail 6211.18 4672.9 -1538.28 (-24.77%) 💔
teams_call_quality 250000 200000 -50000 (-20%) 💔
teams_device_usage_user_counts 5586.59 4424.78 -1161.81 (-20.8%) 💔
teams_user_activity_user_counts 10309.28 6993.01 -3316.27 (-32.17%) 💔
active_users_services_user_counts 4484.3 3584.23 -900.07 (-20.07%) 💔
mailbox_usage_detail 5319.15 3436.43 -1882.72 (-35.4%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh merged commit 65673fa into elastic:main Dec 11, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package cisco_secure_email_gateway - 1.28.3 containing this change is available at https://epr.elastic.co/package/cisco_secure_email_gateway/1.28.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:akamai Akamai (Community supported) Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:o365_metrics Microsoft Office 365 Metrics Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants