- Notifications
You must be signed in to change notification settings - Fork 519
fix: remove tab characters from fields.yml files #16438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewkroh merged 2 commits into elastic:main from andrewkroh:bugfix/remove-tabs-fields-yml Dec 11, 2025
Merged
fix: remove tab characters from fields.yml files #16438
andrewkroh merged 2 commits into elastic:main from andrewkroh:bugfix/remove-tabs-fields-yml Dec 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1f44b41 to 012b122 Compare Removed tab characters from field descriptions in multiple packages that were causing validation issues. Tab characters appeared both as leading whitespace and trailing characters in description values. Affected packages: - akamai: removed trailing tab from client_reputation description - checkpoint_harmony_endpoint: removed leading tabs from multiple field descriptions across antibot, zerophishing, urlfiltering, forensics, and threatextraction data streams - o365_metrics: removed leading tab from caller_network description - cisco_secure_email_gateway: removed tab from upload.action description and improved clarity of field documentation Additionally improved the upload.action field description in cisco_secure_email_gateway to be more concise and clearer based on official Cisco documentation. Fixes elastic#15913
012b122 to 561d780 Compare | Pinging @elastic/integration-experience (Team:Integration-Experience) |
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
taylor-swanson approved these changes Dec 9, 2025
chemamartinez approved these changes Dec 10, 2025
🚀 Benchmarks reportPackage |
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
antibot | 2518.89 | 1485.88 | -1033.01 (-41.01%) | 💔 |
antimalware | 4672.9 | 2247.19 | -2425.71 (-51.91%) | 💔 |
forensics | 4184.1 | 2906.98 | -1277.12 (-30.52%) | 💔 |
threatextraction | 4366.81 | 3164.56 | -1202.25 (-27.53%) | 💔 |
urlfiltering | 3703.7 | 2958.58 | -745.12 (-20.12%) | 💔 |
Package o365_metrics 👍(12) 💚(2) 💔(7)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
outlook_app_usage_version_counts | 8474.58 | 6802.72 | -1671.86 (-19.73%) | 💔 |
sharepoint_site_usage_detail | 6211.18 | 4672.9 | -1538.28 (-24.77%) | 💔 |
teams_call_quality | 250000 | 200000 | -50000 (-20%) | 💔 |
teams_device_usage_user_counts | 5586.59 | 4424.78 | -1161.81 (-20.8%) | 💔 |
teams_user_activity_user_counts | 10309.28 | 6993.01 | -3316.27 (-32.17%) | 💔 |
active_users_services_user_counts | 4484.3 | 3584.23 | -900.07 (-20.07%) | 💔 |
mailbox_usage_detail | 5319.15 | 3436.43 | -1882.72 (-35.4%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
muthu-mps approved these changes Dec 11, 2025
| Package cisco_secure_email_gateway - 1.28.3 containing this change is available at https://epr.elastic.co/package/cisco_secure_email_gateway/1.28.3/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:akamai Akamai (Community supported) Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:o365_metrics Microsoft Office 365 Metrics Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
grep -rn $'\t' packages/**/fields/*.ymlRelated issues
References