Skip to content

Logstash package #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 23, 2021
Merged

Logstash package #1555

merged 12 commits into from
Sep 23, 2021

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Aug 25, 2021 •
edited
Loading

What does this PR do?

Add Logstash integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

image

image

image
@sayden sayden added enhancement New feature or request Team:Integrations Label for the Integrations team labels Aug 25, 2021
@sayden sayden self-assigned this Aug 25, 2021
@elasticmachine
Copy link

elasticmachine commented Aug 25, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-23T14:48:51.561+0000

  • Duration: 13 min 17 sec

  • Commit: 54a30fb

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@sayden sayden changed the title Logstash integration Logstash package Aug 25, 2021
@sayden sayden added the Team:Services (Deprecated) Label for the former Integrations-Services team label Aug 26, 2021
@sayden sayden marked this pull request as ready for review September 3, 2021 16:22
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)
@elasticmachine
Copy link

Pinging @elastic/integrations-services (Team:Services)
@masci masci requested a review from a team September 9, 2021 14:24
mtojek
mtojek reviewed Sep 10, 2021
View reviewed changes
packages/logstash/data_stream/log/manifest.yml Outdated
@@ -0,0 +1,18 @@
type: logs
title: logstash log logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this sounds a bit weird :)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo many titles everywhere. I fixed it, thank you for spotting
packages/logstash/data_stream/log/manifest.yml Outdated
- /var/log/logstash/logstash-json*.log
template_path: log.yml.hbs
title: Logstash logs
description: Collect Logstash logs using the log input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe "Collect Logstash logs from standard files?"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, thank you!
packages/logstash/data_stream/node/fields/ecs.yml
external: ecs
- name: service.address
type: keyword
description: Address where data about this service was collected from.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I will be available in 1.12: elastic/ecs#1534
packages/logstash/data_stream/slowlog/sample_event.json Outdated
@@ -0,0 +1 @@
{} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is on purpose empty?
Copy link
Contributor Author

@sayden sayden Sep 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, thanks! I ran into some issues and I'll probably update this in some follow-up. I deleted them by now.
mtojek
mtojek approved these changes Sep 13, 2021
View reviewed changes
packages/logstash/_dev/build/build.yml Outdated
@@ -0,0 +1,3 @@
dependencies:
ecs:
reference: git@1.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I guess you can update it to 1.12. It should be available.
@sayden
Copy link
Contributor Author

sayden commented Sep 23, 2021

ECS 1.12 will be updated in a follow up, once it is released in Github. Merging is possible
@sayden sayden merged commit c534b73 into elastic:master Sep 23, 2021
@sayden sayden deleted the migration/sm/logstash branch July 30, 2022 05:57
@andrewkroh andrewkroh added Integration:elasticsearch Elasticsearch Integration:logstash Logstash New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:elasticsearch Elasticsearch Integration:logstash Logstash New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team

4 participants

@sayden @elasticmachine @mtojek @andrewkroh