Skip to content

[arista_ngfw] Generate processor tags and normalize error handler #15524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taylor-swanson merged 3 commits into from
Oct 28, 2025
Merged

[arista_ngfw] Generate processor tags and normalize error handler #15524

taylor-swanson merged 3 commits into from
Oct 28, 2025

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Oct 3, 2025 •
edited
Loading

Proposed commit message

  • Generate tags for processors missing tags
  • Normalize the pipeline error handler
  • Removed duplicate processors

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices
@taylor-swanson taylor-swanson self-assigned this Oct 3, 2025
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:arista_ngfw Arista NG Firewall (Community supported) Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Oct 3, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 3, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@taylor-swanson taylor-swanson marked this pull request as ready for review October 6, 2025 12:54
@taylor-swanson taylor-swanson requested a review from a team as a code owner October 6, 2025 12:54
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2025

Pinging @elastic/integration-experience (Team:Integration-Experience)
qcorporation
qcorporation reviewed Oct 6, 2025
View reviewed changes
packages/arista_ngfw/data_stream/log/elasticsearch/ingest_pipeline/admin_login.yml Outdated
ctx.event.provider = params.get((ctx.arista.succeeded).toString()).get('provider');
ctx.arista.remove('succeeded');
tag: script_cef61fad
Copy link
Contributor

@qcorporation qcorporation Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need a space after for the comment
qcorporation
qcorporation reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@qcorporation qcorporation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I like it - the tag however after the script processors are a bit hard to read due to spacing, it is at all possible to add them at the top of the processor instead of at the end? would that complicate things greatly?
@taylor-swanson taylor-swanson marked this pull request as draft October 6, 2025 14:52
@taylor-swanson
Copy link
Contributor Author

taylor-swanson commented Oct 6, 2025 •
edited
Loading

In general I like it - the tag however after the script processors are a bit hard to read due to spacing, it is at all possible to add them at the top of the processor instead of at the end? would that complicate things greatly?

Not sure, but I'll look into it.

I'm putting this one back into draft, I forgot to run the duplicate tag checker and 6 of the generated tags are duplicates (likely because the processors themselves were repeated). Either way, looking into that as well.

Edit: these are the 6 duplicated tags, all resulting in duplicated processors.

duplicate tag "convert_b57304ca" found in processor duplicate tag "convert_0c5a9349" found in processor duplicate tag "geoip_da2e41b2" found in processor duplicate tag "geoip_28d69883" found in processor duplicate tag "rename_a917047d" found in processor duplicate tag "rename_f1362d0b" found in processor

I initially had the index of the processor influencing the hash, but I removed it. I'm glad I did, because it's finding these duplicated processors.
@taylor-swanson
Copy link
Contributor Author

taylor-swanson commented Oct 6, 2025

/test
@taylor-swanson
[arista_ngfw]: Generate pipeline tags and normalize error handler
1d7de47 
- Generate tags for processors missing tags - Normalize the pipeline error handler
@taylor-swanson
normalize error handler
7d616de
@taylor-swanson
changelog
42146a6
@taylor-swanson taylor-swanson force-pushed the enhance/tag-arista-ngfw branch from 7bd90d9 to 42146a6 Compare October 21, 2025 14:48
@taylor-swanson taylor-swanson marked this pull request as ready for review October 21, 2025 14:53
@elasticmachine
Copy link

elasticmachine commented Oct 21, 2025

💚 Build Succeeded

History

cc @taylor-swanson
@taylor-swanson taylor-swanson merged commit f093f01 into elastic:main Oct 28, 2025
7 checks passed
@taylor-swanson taylor-swanson deleted the enhance/tag-arista-ngfw branch October 28, 2025 12:41
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 28, 2025

Package arista_ngfw - 1.4.2 containing this change is available at https://epr.elastic.co/package/arista_ngfw/1.4.2/
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@taylor-swanson
[arista_ngfw] Generate processor tags and normalize error handler (el…
09d4395 
…astic#15524) - Generate tags for processors missing tags - Normalize the pipeline error handler - Removed duplicate processors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:arista_ngfw Arista NG Firewall (Community supported) Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

4 participants

@taylor-swanson @elasticmachine @qcorporation @haetamoudi