Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

@brijesh-elastic brijesh-elastic commented Sep 25, 2025

Proposed commit message

microsoft_defender_endpoint: ensure `page_size` configuration is preserved in CEL evaluation responses For the machine data stream, error handling in the CEL program has been enhanced to prevent 'no such key: page_size' errors by ensuring proper propagation of the state data configuration during failures. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/microsoft_defender_endpoint directory.
  • Run the following command to run tests.

elastic-package test -v

…rrectly formatted in vulnerability data stream
@brijesh-elastic brijesh-elastic self-assigned this Sep 25, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner September 25, 2025 11:37
@brijesh-elastic brijesh-elastic added Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Sep 25, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Sep 25, 2025

🚀 Benchmarks report

Package microsoft_defender_endpoint 👍(2) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
machine_action 6944.44 4739.34 -2205.1 (-31.75%) 💔
vulnerability 1972.39 1669.45 -302.94 (-15.36%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 changed the title [microsoft_defender_endpoint] Improve handling of errors for CEL [microsoft_defender_endpoint] fix error state returns Sep 25, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are handled in #15471. So let's back them out here.

Comment on lines 4 to 9
- description: Ensure large `$skip` API parameter values are correctly formatted in `vulnerability` data stream.
type: bugfix
link: https://github.com/elastic/integrations/pull/1
- description: 'Enhanced error handling in the CEL program for API calls to prevent "no such key: page_size" errors in the machine data stream.'
type: bugfix
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Ensure large `$skip` API parameter values are correctly formatted in `vulnerability` data stream.
type: bugfix
link: https://github.com/elastic/integrations/pull/1
- description: 'Enhanced error handling in the CEL program for API calls to prevent "no such key: page_size" errors in the machine data stream.'
type: bugfix
link: https://github.com/elastic/integrations/pull/1
- description: 'Ensure `page_size` configuration is preserved in CEL evaluation responses.'
type: bugfix
link: https://github.com/elastic/integrations/pull/15467

This is not really an error handing issue, this is a invariant correctness issue.

@brijesh-elastic brijesh-elastic changed the title [microsoft_defender_endpoint] fix error state returns [microsoft_defender_endpoint] ensure page_size configuration is preserved in CEL evaluation responses Sep 26, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@brijesh-elastic brijesh-elastic merged commit fa0ef1f into elastic:main Sep 26, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package microsoft_defender_endpoint - 3.1.2 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/3.1.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

3 participants