- Notifications
You must be signed in to change notification settings - Fork 513
crowdstrike: improve windows events mappings in FDR data stream #15342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage |
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
falcon | 6896.55 | 5076.14 | -1820.41 (-26.4%) | 💔 |
To see the full report comment with /test benchmark fullreport
600d541 to 171497b Compare | '1': | ||
| type: change | ||
| action: modification | ||
| '2': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
171497b to eb9d811 Compare | Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but will wait for @w0rk3r before approving.
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
Conflicts: packages/crowdstrike/changelog.yml
w0rk3r left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work, some of the asked changes are still missing, but we are close. Thanks!
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
💚 Build Succeeded
History
|
|
efd6 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we will wait for confirmation from @w0rk3r.
w0rk3r left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, looks g2g for me
| Package crowdstrike - 2.4.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/2.4.0/ |
| Thank you all! |





Proposed commit message
Note
For all events:
aidtohost.id.ContextProcessIdtoprocess.entity_id(mappingParentProcessIdtoprocess.parent.entity_idis already present) in network, file, configuration, registry, driver events.Registry events (
event.category=registry):RegCrowdstrikeKeyUpdateRegCrowdstrikeValueUpdate\) in the start ofregistry.key.crowdstrike.RegOperationTypeRegOperationType 3event.typeis set to both change and creation, should be creation onlyRegOperationType 4event.typeis set change, but it is related to deletion, we should set it to deletion, and don’t populate the >event.typewith change by default.File events (
event.category=file):crowdstrike.OriginalFilenameis being mapped toprocess.pe.original_file_name:file.pe.original_file_nameinsteaduser.idis not populatedFileOperatorSidto populate it when presentevent.typeto creation onFileDetectInfoevents.NewExecutableRenamedandFileRenameInfoevent.actionvalues:crowdstrike.TargetFileNameto populatefile.pathfile.namecrowdstrike.SourceFileNameto populatefile.Ext.original.pathfile.Ext.original.nameLibrary events (
event.category=library):crowdstrike.OriginalFilenameis being mapped toprocess.pe.original_file_name:dll.pe.original_file_nameinsteaddll.code_signature.trustedis being populated withtrueeven for unsigned DLLsImageSignatureLevel 2isENTERPRISE (0x2), but when I tested with an unsigned DLL it was populated with > 2. However, we can combine it withImageSignatureTypeso it becomes more reliable.ImageSignatureType == 0 (NONE (0x0)):dll.code_signature.existstofalsedll.code_signature.trustedtofalseImageSignatureType >= 1andImageSignatureLevelis0or1:dll.code_signature.existstotruedll.code_signature.trustedtofalseImageSignatureType >= 1andImageSignatureLevel >= 2:dll.code_signature.existstotruedll.code_signature.trustedtotrueprocess.pid, I mistakenly suggested that we could useContextProcessIdto populate it, but considering other events, this > doesn’t make senseDriver events for when (
event.categoryisdriver):crowdstrike.OriginalFilenameis being mapped toprocess.pe.original_file_name:dll.pe.original_file_nameinsteadCertificatePublishercan used to populatedll.code_signature.subject_nameImageFileNamecan used to populatedll.pathdll.namecan be extracted from theImageFileNamepathContextProcessIdcan used to populateprocess.entity_idevent.actioncan be set toloadSHA256HashDatacan used to populatedll.hash.sha256MD5HashDatacan used to populatedll.hash.md5ServiceDisplayNamecan used to populateservice.nameAdditional adjustments:
Misclassification of events as
malwaremalwarefromevent.categoryfor the following events:AssociateIndicatorSensitiveWmiQueryevent.categoryprocessonly, notmalwareSuspiciousCreateSymbolicLinkmalwarevalue, keep thefileDetectionExcludedevent.categoryconfiguration, notmalwareRegistryOperationDetectInfomalwarevalue, keep theregistryOveruse of
event.kind: alertevent.kind == alerttoo broadly promotes many irrelevant events to security alerts, Setevent.kindtoeventfor following > events:ErrorEventRansomwareOpenFileRansomwareCreateFileModifyServiceBinaryDetectionExcludedSensitiveWmiQueryFileSystemOperationDetectInfoChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots