Skip to content

Conversation

@clement-fouque
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@andrewkroh andrewkroh added the Integration:qualys_gav Qualys Global AssetView label Sep 16, 2025
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Sep 16, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@clement-fouque clement-fouque marked this pull request as ready for review September 17, 2025 15:21
@clement-fouque clement-fouque requested a review from a team as a code owner September 17, 2025 15:21
@clement-fouque
Copy link
Contributor Author

@elastic/security-service-integrations can you please review this PR? Thanks.

@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Sep 17, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
64.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@clement-fouque
Copy link
Contributor Author

I've implemented the recommendations. Can you please review and approve if fine? Thanks.

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-fouque clement-fouque merged commit 19fbc06 into elastic:main Sep 29, 2025
8 of 9 checks passed
@clement-fouque clement-fouque deleted the 15158-qualys_gav-cloud_provider branch September 29, 2025 07:22
@elastic-vault-github-plugin-prod

Package qualys_gav - 0.2.0 containing this change is available at https://epr.elastic.co/package/qualys_gav/0.2.0/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
* Add fields mapping for Qualys field cloudProvider * refactor: change cloud provider field to lowercase from asset provider * Add field mappings for cloud_provider * Rebuild package * Add change details for new version * Add cloud_provider in the sample event * Fix test for field cloud_provider * Regenerate package and doc * Implement requested changes * Implement recommendations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:qualys_gav Qualys Global AssetView Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants