Skip to content

Conversation

@bhapas
Copy link
Contributor

@bhapas bhapas commented Sep 9, 2025

Proposed commit message

Support special characters in interface name for 315011 log messages

Currently it fails if there is a Hyphen - character in interface name.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

elastic-package stack up -d -v & elastic-package test pipeline

Related issues

@bhapas bhapas self-assigned this Sep 9, 2025
@bhapas bhapas requested a review from a team as a code owner September 9, 2025 08:17
@bhapas bhapas added Integration:cisco_asa Cisco ASA bugfix Pull request that fixes a bug issue labels Sep 9, 2025
@bhapas bhapas force-pushed the fix_cisco_asa_315011 branch from 9763952 to bf23b3c Compare September 9, 2025 08:20
Copy link
Contributor

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bhapas bhapas enabled auto-merge (squash) September 9, 2025 08:30
@bhapas bhapas force-pushed the fix_cisco_asa_315011 branch from 94085d1 to cf70301 Compare September 9, 2025 08:39
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@bhapas bhapas merged commit aee01a4 into elastic:main Sep 9, 2025
7 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @bhapas

@elastic-vault-github-plugin-prod

Package cisco_asa - 2.43.8 containing this change is available at https://epr.elastic.co/package/cisco_asa/2.43.8/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA

3 participants