Skip to content

[crowdstrike] Added a conditional JSON parsing workaround for ResourceAttributes #15019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

[crowdstrike] Added a conditional JSON parsing workaround for ResourceAttributes #15019

merged 2 commits into from
Aug 22, 2025

Conversation

@brijesh-elastic
Copy link
Collaborator

@brijesh-elastic brijesh-elastic commented Aug 22, 2025 •
edited
Loading

Proposed commit message

crowdstrike: Implemented a conditional JSON parsing workaround for `ResourceAttributes` to handle cases where custom rules convert the object into a JSON string, ensuring consistent ingestion of documents.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/crowdstrike directory.
  • Run the following command to run tests.

elastic-package test
@brijesh-elastic
Added a conditional JSON parsing workaround for ResourceAttributes to…
d4a7faf 
… handle cases where it is rendered as a JSON string
@brijesh-elastic brijesh-elastic self-assigned this Aug 22, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner August 22, 2025 10:00
@brijesh-elastic brijesh-elastic added Integration:crowdstrike CrowdStrike bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Aug 22, 2025
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2025

💚 Build Succeeded

cc @brijesh-elastic
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 22, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
11.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
ShourieG
ShourieG approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@brijesh-elastic brijesh-elastic merged commit 3e21867 into elastic:main Aug 22, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 22, 2025

Package crowdstrike - 2.0.1 containing this change is available at https://epr.elastic.co/package/crowdstrike/2.0.1/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:crowdstrike CrowdStrike Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

3 participants

@brijesh-elastic @elasticmachine @ShourieG