Skip to content

splunk: use config auth instead of manual header handling #15000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

splunk: use config auth instead of manual header handling #15000

merged 1 commit into from
Aug 21, 2025

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Aug 21, 2025 •
edited
Loading

Proposed commit message

splunk: use config auth instead of manual header handling There is no reason to use the constructed request approach to API requests in this data stream, so avoid it and the complication and secret-leak risks that it brings.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Aug 21, 2025
@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:splunk Splunk labels Aug 21, 2025
@efd6
splunk: use config auth instead of manual header handling
80f6054 
There is no reason to use the constructed request approach to API requests in this data stream, so avoid it and the complication and secret-leak risks that it brings.
@efd6 efd6 force-pushed the splunk_config_auth branch from 3023d4d to 80f6054 Compare August 21, 2025 05:18
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 21, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 21, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented Aug 21, 2025

💚 Build Succeeded

cc @efd6
@efd6 efd6 marked this pull request as ready for review August 21, 2025 05:46
@efd6 efd6 requested a review from a team as a code owner August 21, 2025 05:46
@elasticmachine
Copy link

elasticmachine commented Aug 21, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@efd6 efd6 merged commit 5a64d16 into elastic:main Aug 21, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 21, 2025

Package splunk - 0.6.0 containing this change is available at https://epr.elastic.co/package/splunk/0.6.0/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:splunk Splunk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @chemamartinez