Skip to content

Remove unused httpjson agent file from {zeek, apache, windows, aws.cloudtrail, nginx} #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 25, 2025
Merged

Remove unused httpjson agent file from {zeek, apache, windows, aws.cloudtrail, nginx} #14995

merged 8 commits into from
Aug 25, 2025

Conversation

@vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Aug 20, 2025 •
edited
Loading

Proposed commit message

httpjson input was removed from these integrations in this PR. However, the agent files were still there with the package.

This PR removes those unused httpjson files.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image image image image image
@vinit-chauhan vinit-chauhan added the bugfix Pull request that fixes a bug issue label Aug 20, 2025
@vinit-chauhan vinit-chauhan marked this pull request as ready for review August 20, 2025 19:14
@vinit-chauhan vinit-chauhan requested review from a team as code owners August 20, 2025 19:14
@vinit-chauhan vinit-chauhan self-assigned this Aug 20, 2025
@qcorporation qcorporation added the Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] label Aug 20, 2025
@elasticmachine
Copy link

elasticmachine commented Aug 20, 2025

Pinging @elastic/integration-experience (Team:Integration-Experience)
@vinit-chauhan vinit-chauhan added Integration:windows Windows Integration:apache Apache HTTP Server Integration:aws AWS Integration:zeek Zeek Integration:nginx Nginx Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Aug 20, 2025
@elasticmachine
Copy link

elasticmachine commented Aug 20, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)
@elasticmachine
Copy link

elasticmachine commented Aug 20, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elasticmachine
Copy link

elasticmachine commented Aug 20, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)
muthu-mps
muthu-mps reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enable_request_tracer is specific to httpjson which exists here. This is applicable for the AWS and Nginx integration too. Can this parameter removed from test_config? WDYT?
@efd6
Copy link
Contributor

efd6 commented Aug 21, 2025

The enable_request_tracer is specific to httpjson which exists here. This is applicable for the AWS and Nginx integration too. Can this parameter removed from test_config? WDYT?

Yeah, that should be removed.
efd6
efd6 reviewed Aug 21, 2025
View reviewed changes
packages/apache/manifest.yml Outdated
# yvgJ38BRsFOtkRuAGSf6ZUwTO8JJRRIFnpUzXflAnGivK9M13D5GEQMmIl6U9Pvk
# sxSmbIUfc2SGJGCJD4I=
# -----END CERTIFICATE-----
# -----END CERTIFICATE-----
Copy link
Contributor

@efd6 efd6 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# -----END CERTIFICATE-----
# -----END CERTIFICATE-----
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 21, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented Aug 21, 2025

💚 Build Succeeded

History

cc @vinit-chauhan
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 21, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
efd6
efd6 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for cert fix.
@muthu-mps muthu-mps changed the title Remove unused httpjson agent file from {zeek, apache, system, windows, aws.cloudtrail, nginx} Remove unused httpjson agent file from {zeek, apache, windows, aws.cloudtrail, nginx} Aug 22, 2025
gizas
gizas reviewed Aug 22, 2025
View reviewed changes
packages/nginx/data_stream/access/_dev/test/system/test-default-config.yml
vars:
paths:
- "{{SERVICE_LOGS_DIR}}/access.log*"
enable_request_tracer: true
Copy link
Contributor

@gizas gizas Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed? Was only for httpjson?
Copy link
Contributor Author

@vinit-chauhan vinit-chauhan Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is httpjson specific, and used for system tests.
@vinit-chauhan vinit-chauhan merged commit 342925a into elastic:main Aug 25, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 25, 2025

Package apache - 2.1.1 containing this change is available at https://epr.elastic.co/package/apache/2.1.1/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 25, 2025

Package aws - 3.14.2 containing this change is available at https://epr.elastic.co/package/aws/3.14.2/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 25, 2025

Package nginx - 2.3.2 containing this change is available at https://epr.elastic.co/package/nginx/2.3.2/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 25, 2025

Package windows - 3.1.2 containing this change is available at https://epr.elastic.co/package/windows/3.1.2/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 25, 2025

Package zeek - 3.0.2 containing this change is available at https://epr.elastic.co/package/zeek/3.0.2/
@vinit-chauhan vinit-chauhan deleted the remove_httpjson_template branch September 26, 2025 14:57
@vinit-chauhan vinit-chauhan restored the remove_httpjson_template branch September 26, 2025 14:57
@vinit-chauhan vinit-chauhan deleted the remove_httpjson_template branch September 26, 2025 14:57
@herrBez herrBez mentioned this pull request Nov 6, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:apache Apache HTTP Server Integration:aws AWS Integration:nginx Nginx Integration:windows Windows Integration:zeek Zeek Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

10 participants

@vinit-chauhan @elasticmachine @efd6 @gizas @mjwolf @kgeller @nfritts @andrzej-stencel @muthu-mps @qcorporation