- Notifications
You must be signed in to change notification settings - Fork 519
ti_abusech: Update readme content and UI layout #14774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| ### ECS field reference | ||
| | ||
| {{fields "malware"}} | ||
| | ||
| {{fields "malwarebazaar"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgeller, here the generated content could be better.
The collapsable Exported fields sections are listed without knowing which dataset they belong to. It would've been nice if the exported_fields has data stream name just like sample_event.
This wasn't a problem with #14271 as it only contained 1 dataset.
May I know your suggestion here? Do you suggest adding more headers (for each data stream) like we currently have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
I'd say we could change it to have the datastream headers, but I'd love to get the opinion of @alaudazzi and @benironside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense @kgeller -- adding a header to each data stream would be ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alaudazzi @kgeller I added the headers. Please review and approve the PR if everything looks good.
| ## What do I need to use this integration? | ||
| | ||
| ### From Elastic | ||
| | ||
| This integration supports both Elastic Agentless-based and Agent-based installations. | ||
| | ||
| #### Agentless-based installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgeller, can you confirm which section does installation instructions for Agentless and Agent should go under?
As per the template, all Elastic prerequisites should be under ## What do I need to use this integration, but also the template says the agent instructions should be under ## How do I deploy this integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alaudazzi @benironside could you provide guidance here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the agent instructions under ## How do I deploy this integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alaudazzi I updated the section. Please review and approve the PR if everything looks good.
🚀 Benchmarks reportTo see the full report comment with |
kgeller left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated README lgtm 👍
alaudazzi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and left some editing suggestions. The structure looks OK.
💚 Build Succeeded
History
cc @kcreddy |
|
| Package ti_abusech - 3.3.0 containing this change is available at https://epr.elastic.co/package/ti_abusech/3.3.0/ |
Update the abuse.ch readme to improve the readability and improve the setup experience for users of the integration. Ensure consistency in configuration options and descriptions. Rebrand AbuseCH to abuse.ch.
Update the abuse.ch readme to improve the readability and improve the setup experience for users of the integration. Ensure consistency in configuration options and descriptions. Rebrand AbuseCH to abuse.ch.




Proposed commit message
Checklist
changelog.ymlfile.Related issues
Screenshots