Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 28, 2025

Proposed commit message

ti_abusech: add ja3_fingerprints and sslblacklist data streams Bump to kibana.version is required to pick up transformMapEntry CEL macro. Test samples obtained from the relevant API endpoints. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 28, 2025
@efd6 efd6 added enhancement New feature or request Integration:ti_abusech abuse.ch Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 28, 2025
@efd6 efd6 force-pushed the 14495-ti_abusech branch 2 times, most recently from b771d1a to d76fade Compare July 28, 2025 04:22
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 28, 2025

🚀 Benchmarks report

Package ti_abusech 👍(12) 💚(0) 💔(0)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
sslblacklist 0 23255.81 23255.81 ( - %) 👍
threatfox 0 19230.77 19230.77 ( - %) 👍
url 0 15384.62 15384.62 ( - %) 👍
ja3_fingerprints 0 6688.96 6688.96 ( - %) 👍
malware 0 11325.03 11325.03 ( - %) 👍
malwarebazaar 0 11534.03 11534.03 ( - %) 👍
sslblacklist 0 19157.09 19157.09 ( - %) 👍
threatfox 0 10822.51 10822.51 ( - %) 👍
url 0 8347.25 8347.25 ( - %) 👍
ja3_fingerprints 0 15384.62 15384.62 ( - %) 👍
malware 0 17543.86 17543.86 ( - %) 👍
malwarebazaar 0 14705.88 14705.88 ( - %) 👍
@efd6 efd6 force-pushed the 14495-ti_abusech branch from d76fade to 5d85e66 Compare July 30, 2025 23:04
@efd6 efd6 marked this pull request as ready for review July 31, 2025 00:00
@efd6 efd6 requested a review from a team as a code owner July 31, 2025 00:00
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the 14495-ti_abusech branch 2 times, most recently from 8d1042a to bc53e9c Compare July 31, 2025 05:30
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 31, 2025
@efd6 efd6 force-pushed the 14495-ti_abusech branch 2 times, most recently from e47427e to a965ff1 Compare July 31, 2025 23:02
Bump to kibana.version is required to pick up transformMapEntry CEL macro. Test samples obtained from the relevant API endpoints.
@efd6 efd6 force-pushed the 14495-ti_abusech branch from a965ff1 to a3b878d Compare July 31, 2025 23:11
@efd6 efd6 force-pushed the 14495-ti_abusech branch from 3879906 to 4b4c59e Compare July 31, 2025 23:40
@kcreddy
Copy link
Contributor

kcreddy commented Aug 4, 2025

/test benchmark fullreport

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits and clarification. LGTM overall.

- name: threat.feed.name
type: constant_keyword
description: Display friendly feed name
value: AbuseCH URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: AbuseCH URL
value: AbuseCH JA3 Fingerprint Blacklist
required: true
show_user: true
default: 1h
description: Interval for polling indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Interval for polling indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
description: Interval for polling threat indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snap!

- name: threat.feed.name
type: constant_keyword
description: Display friendly feed name
value: AbuseCH URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: AbuseCH URL
value: AbuseCH SSL Certificate Blacklist
required: true
show_user: true
default: 1h
description: Interval for polling indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Interval for polling indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
description: Interval for polling threat indicators from AbuseCH data dump. As data dump is generated every 5 minutes, it should be greater than 5 minutes. Default `1h`.
- event.dataset
- threat.indicator.name
sort: "@timestamp"
description: Latest Abuse CH URL data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Latest Abuse CH URL data.
description: Latest Abuse CH SSL Certificate Blacklist data.
- event.dataset
- threat.indicator.name
sort: "@timestamp"
description: Latest Abuse CH URL data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Latest Abuse CH URL data.
description: Latest Abuse CH JA3 Fingerprint Blacklist data.
conditions:
kibana:
version: "^8.18.0 || ^9.0.0"
version: "^8.19.0 || ^9.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for using two var comprehensions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
49.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6 efd6 merged commit 026e3f3 into elastic:main Aug 6, 2025
8 of 9 checks passed
@elastic-vault-github-plugin-prod

Package ti_abusech - 3.2.0 containing this change is available at https://epr.elastic.co/package/ti_abusech/3.2.0/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
…ic#14703) Bump to kibana.version is required to pick up transformMapEntry CEL macro. Test samples obtained from the relevant API endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:ti_abusech abuse.ch Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants