Skip to content

Conversation

@mohitjha-elastic
Copy link
Collaborator

Proposed commit message

elastic_security: Align process fields with ECS and modify `*.supplemental_groups` type handling. Applied `external: ecs` to process-specific fields to align with ECS definitions and avoid manual duplication of field types. Updated the ingest pipeline to convert all `*.supplemental_groups.id` fields from numeric to string (keyword) to match the expected ECS data type. These changes ensure better compatibility with ECS and resolve existing type mismatch issues in process-related fields. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/elastic_security directory.
  • Run the following command to run tests.

elastic-package test -v

Related Issue

@mohitjha-elastic mohitjha-elastic self-assigned this Jul 22, 2025
@mohitjha-elastic mohitjha-elastic requested a review from a team as a code owner July 22, 2025 11:36
@mohitjha-elastic mohitjha-elastic added enhancement New feature or request Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jul 22, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

…elastic_security-0.2.0 Conflicts:	packages/elastic_security/changelog.yml
@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:elastic_security Elastic Security and removed Integration:github GitHub labels Jul 22, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 22, 2025

🚀 Benchmarks report

Package elastic_security 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 1432.66 1033.06 -399.6 (-27.89%) 💔

To see the full report comment with /test benchmark fullreport

fields:
- name: id
type: keyword
description: "The id of tactic used by this threat. You can use a MITRE ATT&CK® tactic, for example. (ex. https://attack.mitre.org/tactics/TA0002/ )"
Copy link
Contributor

@kcreddy kcreddy Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "The id of tactic used by this threat. You can use a MITRE ATT&CK® tactic, for example. (ex. https://attack.mitre.org/tactics/TA0002/ )"
description: The id of tactic used by this threat.

Same for the rest.

Reframe the description of the fields in fields.yml
@mohitjha-elastic mohitjha-elastic requested a review from kcreddy July 24, 2025 07:10
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mohitjha-elastic

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitjha-elastic mohitjha-elastic merged commit 7df1ec5 into elastic:main Jul 25, 2025
9 checks passed
@mohitjha-elastic mohitjha-elastic deleted the elastic_security-0.2.0 branch July 25, 2025 05:42
@elastic-vault-github-plugin-prod

Package elastic_security - 0.3.0 containing this change is available at https://epr.elastic.co/package/elastic_security/0.3.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:elastic_security Elastic Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

4 participants