Skip to content

Conversation

@agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

Add the raft dataset to the Kafka integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Kafa 4.0 integration testing

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas self-assigned this Jul 22, 2025
@agithomas agithomas marked this pull request as ready for review July 22, 2025 03:59
@agithomas agithomas requested a review from a team as a code owner July 22, 2025 03:59
@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 22, 2025
@andrewkroh andrewkroh added the enhancement New feature or request label Aug 7, 2025
Copy link
Contributor

@stefans-elastic stefans-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small questions and the rest LGTM

multi: false
required: false
show_user: false
- name: connect_timeout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config options are valid for jmx input ?
I thought they were http specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same configs present under jolokia input, https://github.com/elastic/integrations/blob/main/packages/jolokia_input/manifest.yml, are considred here.

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, looks good!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
22.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@agithomas agithomas merged commit d9df2a1 into elastic:main Aug 20, 2025
8 of 9 checks passed
@elastic-vault-github-plugin-prod

Package kafka - 1.20.0 containing this change is available at https://epr.elastic.co/package/kafka/1.20.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:kafka Kafka Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

6 participants