Skip to content

snyk: add maximum executions option for data streams #14367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

snyk: add maximum executions option for data streams #14367

merged 1 commit into from
Jun 30, 2025

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jun 29, 2025

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Jun 29, 2025
@efd6 efd6 added enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 29, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 30, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 30, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2025

💚 Build Succeeded

cc @efd6
@efd6 efd6 marked this pull request as ready for review June 30, 2025 01:38
@efd6 efd6 requested a review from a team as a code owner June 30, 2025 01:38
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
chrisberkhout
chrisberkhout approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option looks fine.

I had a look at the pagination logic and for audit logs and I'm curious whether the next links do go stale. The API doc's general pagination advice and endpoint description don't mention that.

In any case, whether using a link in the work list or a time in the cursor, pagination should be able to continue after an interval, so I guess this option is to avoid interval waits during a long initial sync.
@efd6 efd6 merged commit ecb8cd3 into elastic:main Jun 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 30, 2025

Package snyk - 2.1.0 containing this change is available at https://epr.elastic.co/package/snyk/2.1.0/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @chrisberkhout