Skip to content

Conversation

@moxarth-rathod
Copy link
Contributor

Proposed commit message

office_365: populate ECS message field with alert titles from SecurityComplianceAlerts This PR updates the mapping of message ECS field for the SecurityComplianceAlerts events from o365audit.Comments to o365audit.Name field. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/o365 directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@moxarth-rathod moxarth-rathod self-assigned this May 15, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner May 15, 2025 06:25
@moxarth-rathod moxarth-rathod added enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 15, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@moxarth-rathod moxarth-rathod marked this pull request as draft May 15, 2025 06:47
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 15, 2025

🚀 Benchmarks report

Package o365 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 1503.76 1253.13 -250.63 (-16.67%) 💔

To see the full report comment with /test benchmark fullreport

@moxarth-rathod moxarth-rathod marked this pull request as ready for review May 15, 2025 08:25
"ingested": "2025-05-15T05:51:31Z",
"kind": "event",
"original": "{\"Site\":\"d5180cfc-3479-44d6-b410-8c985ac894e3\",\"ObjectId\":\"https://testsiem-my.sharepoint.com/personal/asr_testsiem_onmicrosoft_com/_layouts/15/onedrive.aspx\",\"ItemType\":\"Page\",\"UserKey\":\"i:0h.f|membership|1003200096971f55@live.com\",\"OrganizationId\":\"b86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd\",\"Operation\":\"PageViewed\",\"ClientIP\":\"213.97.47.133\",\"Workload\":\"OneDrive\",\"EventSource\":\"SharePoint\",\"RecordType\":4,\"Version\":1,\"UserId\":\"asr@testsiem.onmicrosoft.com\",\"WebId\":\"8c5c94bb-8396-470c-87d7-8999f440cd30\",\"UserAgent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:72.0) Gecko/20100101 Firefox/72.0\",\"CreationTime\":\"2020-02-07T16:43:53\",\"CustomUniqueId\":true,\"Id\":\"99d005e6-a4c6-46fd-117c-08d7abeceab5\",\"CorrelationId\":\"622b339f-4000-a000-f25f-92b3478c7a25\",\"ListItemUniqueId\":\"59a8433d-9bb8-cfef-6edc-4c0fc8b86875\",\"UserType\":0}",
"original": "{\"Site\":\"d5180cfc-3479-44d6-b410-8c985ac894e3\",\"ObjectId\":\"https://testsiem-my.sharepoint.com/personal/asr_testsiem_onmicrosoft_com/_layouts/15/onedrive.aspx\",\"ItemType\":\"Page\",\"UserKey\":\"i:0h.f|membership|1003200096971f55@live.com\",\"OrganizationId\":\"b86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd\",\"Operation\":\"PageViewed\",\"ClientIP\":\"213.97.47.133\",\"Workload\":\"OneDrive\",\"EventSource\":\"SharePoint\",\"RecordType\":4,\"Version\":1,\"UserId\":\"asr@testsiem.onmicrosoft.com\",\"WebId\":\"8c5c94bb-8396-470c-87d7-8999f440cd30\",\"CreationTime\":\"2020-02-07T16:43:53\",\"UserAgent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:72.0) Gecko/20100101 Firefox/72.0\",\"CustomUniqueId\":true,\"Id\":\"99d005e6-a4c6-46fd-117c-08d7abeceab5\",\"CorrelationId\":\"622b339f-4000-a000-f25f-92b3478c7a25\",\"ListItemUniqueId\":\"59a8433d-9bb8-cfef-6edc-4c0fc8b86875\",\"UserType\":0}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this sample_event.json is unrelated to current change. It is not required.
Please revert this change and update README once again.

Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
@moxarth-rathod moxarth-rathod requested review from efd6 and kcreddy May 16, 2025 06:05
Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
@moxarth-rathod moxarth-rathod requested a review from kcreddy May 19, 2025 05:31
@kcreddy
Copy link
Contributor

kcreddy commented May 19, 2025

/test

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moxarth-rathod can you fix merge conflicts?

@moxarth-rathod moxarth-rathod requested a review from kcreddy May 19, 2025 09:38
@moxarth-rathod
Copy link
Contributor Author

@moxarth-rathod can you fix merge conflicts?

Yes, resolved now.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

@kcreddy kcreddy merged commit c51a962 into elastic:main May 19, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package o365 - 2.16.0 containing this change is available at https://epr.elastic.co/package/o365/2.16.0/

anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
…nceAlerts` events (elastic#13918) o365: populate ECS message field with alert titles from SecurityComplianceAlerts This PR updates the mapping of message ECS field for the SecurityComplianceAlerts events from o365audit.Comments to o365audit.Name field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

4 participants