Skip to content

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Apr 24, 2025

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

## Author's Checklist

How to test this PR locally

Build the filestream and log packages, look at their docs/readme

## Related issues

Screenshots

TODO

@belimawr belimawr added enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Apr 24, 2025
@belimawr belimawr self-assigned this Apr 24, 2025
@belimawr belimawr force-pushed the add-warnings-for-log-to-filestream branch from 139b01e to e0745cd Compare April 24, 2025 14:30
@belimawr belimawr requested a review from rdner April 24, 2025 14:32
@belimawr belimawr marked this pull request as ready for review April 24, 2025 14:47
@belimawr belimawr requested a review from a team as a code owner April 24, 2025 14:47
@belimawr belimawr requested a review from mauri870 April 24, 2025 14:47
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested different wording.

@andrewkroh andrewkroh added Integration:log Custom Logs (Deprecated) Integration:filestream Custom Logs (Filestream) labels Apr 24, 2025
belimawr and others added 2 commits April 24, 2025 12:09
Co-authored-by: Denis <denis@rdner.de>
@belimawr
Copy link
Contributor Author

Thanks @rdner, I accepted all your suggestions and made a wee change: 14796c7

@belimawr belimawr requested a review from rdner April 24, 2025 16:13
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @belimawr

@belimawr belimawr merged commit 4174717 into elastic:main Apr 24, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package filestream - 1.1.2 containing this change is available at https://epr.elastic.co/package/filestream/1.1.2/

@elastic-vault-github-plugin-prod

Package log - 2.4.3 containing this change is available at https://epr.elastic.co/package/log/2.4.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:filestream Custom Logs (Filestream) Integration:log Custom Logs (Deprecated) Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

4 participants