[HAProxy] Ingest Pipeline Fix to handle Malformed URLs #13625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
packages/haproxy/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
harnish-crest-data suggested changes Apr 22, 2025
Contributor
harnish-crest-data left a comment
harnish-crest-data left a comment There was a problem hiding this comment.
Can we add on_failure for other grok processors as well?
andrewkroh added the Team:Obs-InfraObs 
|
💚 Build Succeeded
History
cc @Linu-Elias |
shmsr approved these changes Apr 23, 2025
| Package haproxy - 1.16.1 containing this change is available at https://epr.elastic.co/package/haproxy/1.16.1/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Added
on_failureto the grok processor responsible for parsing thehaproxy.http.request.raw_request_lineChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots
--- Test results for package: haproxy - START ---
╭─────────┬─────────────┬───────────┬────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │
├─────────┼─────────────┼───────────┼────────────────────────────────────────────────────────┼────────┼──────────────┤
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-default.log) │ PASS │ 561.336621ms │
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-error.log) │ PASS │ 643.478378ms │
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-haproxy.log) │ PASS │ 558.67135ms │
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-httplog-no-headers.log) │ PASS │ 896.317671ms │
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-https.log) │ PASS │ 961.719314ms │
│ haproxy │ log │ pipeline │ (ingest pipeline warnings test-tcplog.log) │ PASS │ 809.471137ms │
│ haproxy │ log │ pipeline │ test-default.log │ PASS │ 54.724684ms │
│ haproxy │ log │ pipeline │ test-error.log │ PASS │ 51.935147ms │
│ haproxy │ log │ pipeline │ test-haproxy.log │ PASS │ 89.28647ms │
│ haproxy │ log │ pipeline │ test-httplog-no-headers.log │ PASS │ 83.047782ms │
│ haproxy │ log │ pipeline │ test-https.log │ PASS │ 63.801481ms │
│ haproxy │ log │ pipeline │ test-tcplog.log │ PASS │ 72.415023ms │
╰─────────┴─────────────┴───────────┴────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: haproxy - END ---
Done