Skip to content

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Mar 31, 2025

Proposed commit message

Add the missing storage_account_container configuration option in the advanced setting.

The storage_account_container configuration option allows users to customize the Storage Account container the integration uses to store che event hub partitions checkpoint data.

The configuration option wasn't included in the mainifest.yml file by mistake.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@zmoog zmoog self-assigned this Mar 31, 2025
@zmoog zmoog added bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team Integration:azure_logs Custom Azure Logs labels Mar 31, 2025
@zmoog zmoog marked this pull request as ready for review March 31, 2025 18:01
@zmoog zmoog requested a review from a team as a code owner March 31, 2025 18:01
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Mar 31, 2025
zmoog added 3 commits March 31, 2025 22:52
With the emoji in the title the header is rendered incorrectly.
@bvader
Copy link

bvader commented Mar 31, 2025

@zmoog I tested the following combinations

  • V1 processor with multiple consumers with distinct storage_account_container values
  • V2 processor with multiple consumers without setting storage_account_container
  • V2 processor with multiple consumers with setting a common storage_account_container

All these tests were successful, excellent!!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on description clarity. Change looks good to me otherwise!

@zmoog
Copy link
Contributor Author

zmoog commented Apr 1, 2025

One more question, why do we add link to the processor V2(https://www.elastic.co/guide/en/integrations/current/azure_logs.html#azure_logs-event-hub-processor-v2-only) for V1?

Uhm, the processor_version option currently is located in the 'v2 only section', but I should probably restructure this section into 'processor options' and annotate the v2 options accordingly.

Great point. I'm making the change, thanks!

This brings more clarity in the processor options section.
@zmoog
Copy link
Contributor Author

zmoog commented Apr 1, 2025

@muthu-mps here's the final revision:

CleanShot 2025-04-01 at 13 44 45@2x

CleanShot 2025-04-01 at 13 46 21@2x

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

@zmoog zmoog merged commit 54b5fdc into elastic:main Apr 1, 2025
7 checks passed
@zmoog zmoog deleted the zmoog/fix/custom-azure-logs/add-missing-storage_account_container branch April 1, 2025 13:20
@elastic-vault-github-plugin-prod

Package azure_logs - 0.3.1 containing this change is available at https://epr.elastic.co/package/azure_logs/0.3.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:azure_logs Custom Azure Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Service-Integrations Label for the Observability Service Integrations team

5 participants