Skip to content

[AmazonMQ] Add firehose routing rules for ActiveMQ and RabbitMQ metrics #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

[AmazonMQ] Add firehose routing rules for ActiveMQ and RabbitMQ metrics #13342

merged 2 commits into from
Apr 3, 2025

Conversation

@agithomas
Copy link
Contributor

@agithomas agithomas commented Mar 28, 2025

  • Enhancement

Proposed commit message

Add firehose routing rules for metrics from AWS/AmazonMQ namespaces. Select aws_mq.activemq_metrics and aws_mq.rabbitmq_metrics datasets respectively for ActiveMQ and RabbitMQ metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Pipeline test update
  • Configuring ActiveMQ metricstream for testing
  • Package upgrade test

How to test this PR locally

  • elastic-package build && elastic-package stack up -v -d --services package-registry

Screenshots

Not applicable
@agithomas agithomas self-assigned this Mar 28, 2025
@agithomas agithomas added Integration:awsfirehose Amazon Data Firehose Integration:aws_mq Amazon MQ enhancement New feature or request Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Mar 28, 2025
@agithomas agithomas marked this pull request as ready for review March 28, 2025 10:53
@agithomas agithomas requested a review from a team as a code owner March 28, 2025 10:53
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 28, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Mar 28, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Mar 28, 2025

💚 Build Succeeded

cc @agithomas
@andrewkroh andrewkroh removed the Integration:aws_mq Amazon MQ label Mar 28, 2025
@agithomas agithomas merged commit 1a80dc6 into elastic:main Apr 3, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 3, 2025

Package awsfirehose - 1.6.0 containing this change is available at https://epr.elastic.co/package/awsfirehose/1.6.0/
flexitrev pushed a commit that referenced this pull request Apr 3, 2025
@agithomas @flexitrev
[AmazonMQ] Add firehose routing rules for ActiveMQ and RabbitMQ metri…
6e6fcef 
…cs (#13342) * AmazonMQ Add firehose routing rules for ActiveMQ and RabbitMQ metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:awsfirehose Amazon Data Firehose Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

4 participants

@agithomas @elasticmachine @Kavindu-Dodan @andrewkroh