Fixed transform job definition that was inflating ingest volume #13158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Negative values were cut from the calculation of the delta between the start and end values of the metrics. This was causing the ingest volume to be inflated. Values can be negative when a merge, or document deletion occurs.
3kt added the Team:Stack Monitoring 
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
|
| Package elasticsearch - 1.18.1 containing this change is available at https://epr.elastic.co/package/elasticsearch/1.18.1/ |
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
* Fixed transform job definition that was inflating ingest volume Negative values were cut from the calculation of the delta between the start and end values of the metrics. This was causing the ingest volume to be inflated. Values can be negative when a merge, or document deletion occurs. * Added changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Negative values were cut from the calculation of the delta between the start and end values of the metrics. This was causing the ingest volume to be inflated.
Values can be negative when a merge, or document deletion occurs.
This deletes the
Math.max(0, XX)in the transform job bucket scripts where relevant (ie where the metrics aren't ever-increasing gauges that are reset upon node restart or shard migration)Checklist
changelog.ymlfile.