- Notifications
You must be signed in to change notification settings - Fork 508
[AD Entity Analytics] Fix UserAccountControl Attribute Table #13145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
| Can you provide a screenshot showing the correspondence between the values and the string representation for the cases that have changed so that we can see that the change is correct, or alternatively/additionally, a link that states that this is the table that should be used? |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
packages/entityanalytics_ad/data_stream/user/elasticsearch/ingest_pipeline/entity.yml Outdated Show resolved Hide resolved
| Suggest this for commit message (pending additional information) |
packages/entityanalytics_ad/data_stream/user/elasticsearch/ingest_pipeline/entity.yml Outdated Show resolved Hide resolved
…est_pipeline/entity.yml
| @efd6 we can use the It is the same example from the documentation: https://learn.microsoft.com/en-us/troubleshoot/windows-server/active-directory/useraccountcontrol-manipulate-account-properties
And if we check the table:
|
|
💚 Build Succeeded
History
cc @w0rk3r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added the link for PARTIAL_SECRET_ACCOUNT to the proposed commit message as well.
| Package entityanalytics_ad - 0.10.1 containing this change is available at https://epr.elastic.co/package/entityanalytics_ad/0.10.1/ |
Previous implementation used the MS-SAMR, but the active directory objects use the adschema[1][2][3]. [1]https://learn.microsoft.com/en-us/windows/win32/adschema/a-useraccountcontrol [2]https://learn.microsoft.com/en-us/windows/win32/api/iads/ne-iads-ads_user_flag_enum [3]https://learn.microsoft.com/en-us/troubleshoot/windows-server/active-directory/useraccountcontrol-manipulate-account-properties




Proposed commit message
Summary
Fix the bit table to be compatible with the AD Schema (https://learn.microsoft.com/en-us/windows/win32/adschema/a-useraccountcontrol) instead of MS-SAMR, as it is the implementation used in active directory objects.
Checklist
changelog.ymlfile.How to test this PR locally
elastic-package test pipeline -vRelated issues
Part of https://github.com/elastic/ia-trade-team/issues/537