Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

Set event.type and event.action values based on aws.vpcflow.action.
See reference : https://docs.aws.amazon.com/vpc/latest/userguide/flow-log-records.html

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/aws directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic added Integration:aws AWS Crest Contributions from Crest developement team. Team:Security-External Integrations Label for the Security External Integrations team mapping/pipeline issue Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Mar 13, 2025
@brijesh-elastic brijesh-elastic self-assigned this Mar 13, 2025
@brijesh-elastic brijesh-elastic requested review from a team as code owners March 13, 2025 10:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Mar 13, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.42.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- version: "2.42.1"
- version: "2.43.0"

Enhancements bump minor.

# newer versions go on top
- version: "2.42.1"
changes:
- description: Set event.type and event.action fields in vpcflow logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to change the version, let's also

Suggested change
- description: Set event.type and event.action fields in vpcflow logs.
- description: Set `event.type` and `event.action` fields in vpcflow logs.
@brijesh-elastic brijesh-elastic requested a review from efd6 March 14, 2025 03:31
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package aws 👍(5) 💚(3) 💔(11)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
guardduty 1519.76 1011.12 -508.64 (-33.47%) 💔
inspector 3086.42 1814.88 -1271.54 (-41.2%) 💔
route53_public_logs 15151.52 12345.68 -2805.84 (-18.52%) 💔
route53_resolver_logs 6289.31 5050.51 -1238.8 (-19.7%) 💔
securityhub_findings 1834.86 1390.82 -444.04 (-24.2%) 💔
securityhub_insights 1418.44 892.86 -525.58 (-37.05%) 💔
apigateway_logs 13333.33 7042.25 -6291.08 (-47.18%) 💔
cloudtrail 2070.39 1600 -470.39 (-22.72%) 💔
cloudwatch_logs 500000 200000 -300000 (-60%) 💔
ec2_logs 41666.67 29411.76 -12254.91 (-29.41%) 💔
ec2_metrics 35714.29 28571.43 -7142.86 (-20%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

@brijesh-elastic brijesh-elastic merged commit 11445fa into elastic:main Mar 18, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package aws - 2.43.0 containing this change is available at https://epr.elastic.co/package/aws/2.43.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
* Set event.type and event.action fields in vpcflow logs * Update changelog entry * Bump minor version
@andrewkroh andrewkroh removed the Crest Contributions from Crest developement team. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS mapping/pipeline issue Team:Security-External Integrations Label for the Security External Integrations team Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

6 participants