google_workspace: fix JSON error and login challenge_status handling #13070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added enhancement 
Also improve error reporting for cases where JSON parsing cannot be successfully carried out. Previously JSON parsing failures would be silently ignored leaving no indication that that was the cause of a document not being processed correctly. With the changes here, failing to parse the JSON results in pipeline termination with an informative message since no furthe work can be done without the parsed JSON.
efd6 force-pushed the 12976-google_workspace branch from 6dbe15c to 2e009a9 Compare 
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy approved these changes Mar 13, 2025
| Package google_workspace - 2.34.0 containing this change is available at https://epr.elastic.co/package/google_workspace/2.34.0/ |
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
…13070) Also improve error reporting for cases where JSON parsing cannot be successfully carried out. Previously JSON parsing failures would be silently ignored leaving no indication that that was the cause of a document not being processed correctly. With the changes here, failing to parse the JSON results in pipeline termination with an informative message since no furthe work can be done without the parsed JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots