Skip to content

Conversation

@kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Jan 15, 2025

Proposed commit message

Users may have private IPs inside source.ip which prevents geo fields from getting populated.
This PR:

  • Uses source.nat.ip as an alternate for populating geo fields if not already populated by source.ip.
  • Removes processor explicitly populating geo.country_name as it is added by geoip processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/zscaler_zia && elastic-package build && elastic-package stack up --version=8.13.0 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v

--- Test results for package: zscaler_zia - START --- ╭─────────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├─────────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────┼────────┼──────────────┤ │ zscaler_zia │ firewall │ pipeline │ (ingest pipeline warnings test-firewall-http-endpoint.log) │ PASS │ 348.205541ms │ │ zscaler_zia │ firewall │ pipeline │ (ingest pipeline warnings test-firewall.log) │ PASS │ 333.986667ms │ │ zscaler_zia │ firewall │ pipeline │ (ingest pipeline warnings test-unicode.json) │ PASS │ 372.179208ms │ │ zscaler_zia │ firewall │ pipeline │ test-firewall-http-endpoint.log │ PASS │ 94.69425ms │ │ zscaler_zia │ firewall │ pipeline │ test-firewall.log │ PASS │ 88.065417ms │ │ zscaler_zia │ firewall │ pipeline │ test-unicode.json │ PASS │ 65.712959ms │ ╰─────────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────┴────────┴──────────────╯ --- Test results for package: zscaler_zia - END --- Done 

Related issues

Screenshots

@kcreddy kcreddy self-assigned this Jan 15, 2025
@kcreddy kcreddy added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] and removed enhancement New feature or request labels Jan 15, 2025
@kcreddy kcreddy marked this pull request as ready for review January 15, 2025 11:39
@kcreddy kcreddy requested a review from a team as a code owner January 15, 2025 11:39
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

@kcreddy kcreddy merged commit 6e46d8b into elastic:main Jan 17, 2025
5 checks passed
@kcreddy kcreddy deleted the zscaler_zia-ips branch January 17, 2025 09:34
@elastic-vault-github-plugin-prod

Package zscaler_zia - 3.6.3 containing this change is available at https://epr.elastic.co/package/zscaler_zia/3.6.3/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…wall` and `web` logs. (elastic#12356) Users may have private IPs inside `source.ip` which prevents `geo` fields from getting populated. This PR: - Uses `source.nat.ip` as an alternate for populating `geo` fields if not already populated by `source.ip`. - Removes processor explicitly populating `geo.country_name` as it is added by `geoip` processor.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…wall` and `web` logs. (elastic#12356) Users may have private IPs inside `source.ip` which prevents `geo` fields from getting populated. This PR: - Uses `source.nat.ip` as an alternate for populating `geo` fields if not already populated by `source.ip`. - Removes processor explicitly populating `geo.country_name` as it is added by `geoip` processor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants