Skip to content

Conversation

@alaudazzi
Copy link
Contributor

This PR proposes some editing suggestions.
Closes https://github.com/elastic/integration-docs/issues/626

CC @daniela-elastic

@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Jan 15, 2025
@alaudazzi alaudazzi requested a review from shmsr January 15, 2025 09:58
@alaudazzi alaudazzi self-assigned this Jan 15, 2025
@alaudazzi alaudazzi requested a review from a team as a code owner January 15, 2025 09:58
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr
Copy link
Member

shmsr commented Jan 15, 2025

Here are some suggestions. Rest looks good!

diff --git a/packages/azure_openai/_dev/build/docs/README.md b/packages/azure_openai/_dev/build/docs/README.md index 60a879c37d..7bbf02809d 100644 --- a/packages/azure_openai/_dev/build/docs/README.md +++ b/packages/azure_openai/_dev/build/docs/README.md @@ -1,6 +1,6 @@ # Azure OpenAI Integration -The Azure OpenAI service provides flexibility to build your own copilot and AI applications. The Azure OpenAI integration collects metrics and logs through [azure-monitor](https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/metrics-index) and Azure [event hub](https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/stream-monitoring-data-event-hubs) respectively. +The Azure OpenAI service provides flexibility to build your own copilot and AI applications. The Azure OpenAI integration collects metrics and logs through [azure-monitor](https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/metrics-index) and the Azure [event hub](https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/stream-monitoring-data-event-hubs) respectively. To fully populate the Azure OpenAI dashboard lenses, you have to enable both logs and metrics data streams and set up the Azure Billing integration in advance. @@ -25,15 +25,15 @@ Refer to the [Azure Logs](https://docs.elastic.co/integrations/azure) page for m #### Default Logging -The Azure OpenAI provides native logging and monitoring with which you can track the telemetry of the service. The Audit and RequestResponse log categories come under the native logging. However, the default logging doesn't log the inputs and outputs of the service. This is useful to ensure that the services operates as expected. +The Azure OpenAI provides native logging and monitoring to track the telemetry of the service. The Audit and RequestResponse log categories come under the native logging. However, the default logging doesn't log the inputs and outputs of the service. This is useful to ensure that the service operates as expected. The logs collected using the default cognitive services are listed on the [Monitor OpenAI models](https://learn.microsoft.com/en-us/azure/architecture/ai-ml/openai/architecture/log-monitor-azure-openai#:~:text=Metric-,Default%20Azure%20OpenAI%20logging,-This%20solution) page. #### Advance Logging -The API Management services provide the advance logging capabilities. The `ApiManagementGatewayLogs` category comes under the advance logging. This is not directly available in the Azure OpenAI service itself. You have to set up the API Management services in the Azure to access the Azure OpenAI. When the setup is complete, add the diagnostic setting for the API Management service. +The API Management services provide the advanced logging capabilities. The `ApiManagementGatewayLogs` category comes under the advanced logging. This is not directly available in the Azure OpenAI service itself. You have to set up the API Management services in Azure to access the Azure OpenAI. When the setup is complete, add the diagnostic setting for the API Management service. -For more information on how to implement the comprehensive solution using API Management services to monitor the Azure OpenAI services, check the [Monitor OpenAI models](https://learn.microsoft.com/en-us/azure/architecture/ai-ml/openai/architecture/log-monitor-azure-openai) page.  +For more information on how to implement the comprehensive solution using API Management services to monitor the Azure OpenAI services, check the [Monitor OpenAI models](https://learn.microsoft.com/en-us/azure/architecture/ai-ml/openai/architecture/log-monitor-azure-openai) page. **Diagnostic settings** 
@andrewkroh andrewkroh added Integration:azure_openai Azure OpenAI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jan 15, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20425 succeeded f1b72cc67f489ee3385dc6470932f4b557cb86dd

cc @alaudazzi

@alaudazzi alaudazzi merged commit c7a5976 into main Jan 16, 2025
5 checks passed
@alaudazzi alaudazzi deleted the edit-azure-openai branch January 16, 2025 09:26
@elastic-vault-github-plugin-prod

Package azure_openai - 1.4.2 containing this change is available at https://epr.elastic.co/package/azure_openai/1.4.2/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Editing pass * Integrate reviewer's comments * Update changelog and manifest
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Editing pass * Integrate reviewer's comments * Update changelog and manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:azure_openai Azure OpenAI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants